Small perf improvement to limited incremental sync #17149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/sync_incr
branch
from
59b8435 to
72e73cb
Compare
erikjohnston
force-pushed
the
erikj/sync_incr
branch
from
72e73cb to
0c4580d
Compare
|
cc @richvdh, as this is adding another optimisation on top of the sync state delta work you/we did |
|
Thinking about it, I'm slightly worried that we don't have tests for this case. I'll need to have a think about how we go about doing that 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that we often end up fetching enough events from the DB to fill the gap, but we still end up with a gap due to the timeline limit. However, we can still apply the same optimisation as before to the list of fetched events, rather than just the truncated list we return.