Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional debug logging to MultiWriterIdGenerator.__init__ and get_cache_dict #9443

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments
Open

Add additional debug logging to MultiWriterIdGenerator.__init__ and get_cache_dict #9443

matrixbot opened this issue Dec 18, 2023 · 0 comments
Labels
good first issue This is a fix that might be an easy place for someone to start for their first contribution O-Occasional S-Tolerable T-Task

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023 •
edited
Loading

This issue has been migrated from #9443.

We should add debug logging to MultiWriterIdGenerator similar to that in StreamIdGenerator, per matrix-org/synapse#9268 (comment):

If MultiWriterIdGenerator.__init__ and get_cache_dict included some logger.debug, this would be a lot less confusing to diagonose.

(I mention MultiWriterIdGenerator specifically, because StreamIdGenerator.__init__ does write debug, via _load_current_id, and it is quite helpful, and the inconsistency is extra confusing.)
@matrixbot matrixbot changed the title Dummy issue Add additional debug logging to MultiWriterIdGenerator.__init__ and get_cache_dict Dec 21, 2023
@matrixbot matrixbot added good first issue This is a fix that might be an easy place for someone to start for their first contribution S-Tolerable O-Occasional T-Task labels Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This is a fix that might be an easy place for someone to start for their first contribution O-Occasional S-Tolerable T-Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot