Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether try/catch statement is necessary when building list of target hosts for /make_* endpoints #8808

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #8808.


The do_invite_join, do_remotely_reject_invite and (if matrix-org/synapse#6739 is merged) do_knock all include a similar bit of code for inserting a remote server name at the beginning of a list of target hosts. This code includes a try/catch statement for ValueError that seems unnecessary.

https://github.com/matrix-org/synapse/blob/7127855741faaf9544339db4faa7d25b0158fdfc/synapse/handlers/federation.py#L1360-L1367

https://github.com/matrix-org/synapse/blob/b08dc7effed4a880384e386cdca50c5d15870904/synapse/handlers/federation.py#L1655-L1662

@matrixbot matrixbot changed the title Dummy issue Investigate whether try/catch statement is necessary when building list of target hosts for /make_* endpoints Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant