Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions while parsing EDUs mask the problem area of the source #3297

Open
matrixbot opened this issue Dec 16, 2023 · 0 comments
Open

Exceptions while parsing EDUs mask the problem area of the source #3297

matrixbot opened this issue Dec 16, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 16, 2023

This issue has been migrated from #3297.


Description

Received this error on dev.t2bot.io:

2018-05-27 20:20:21,991 - synapse.federation.transport.server - 148 - INFO - PUT-4244- Request from zemos.net
2018-05-27 20:20:21,991 - synapse.federation.transport.server - 266 - INFO - PUT-4244- Received txn DxKPPsdBfaB6LZyKgAJ6TvpMpj8Lzfp6Qs8RkmHSpp6ot from zemos.net. (PDUs: 0, EDUs: 1, failures: 0)
2018-05-27 20:20:21,996 - synapse.federation.federation_server - 643 - ERROR - PUT-4244- Failed to handle edu 'm.typing'
Traceback (most recent call last):
  File "/home/travis/.synapse/local/lib/python2.7/site-packages/synapse/federation/federation_server.py", line 639, in on_edu
    yield handler(origin, content)
KeyError: 'room_id'

Turns out the error originated from https://github.com/matrix-org/synapse/blob/3c099219e0506f81fc333ff9d27cc3af5c365a2c/synapse/handlers/typing.py#L237

Would be nice to see that in the stack trace at the least, to avoid having to reverse engineer the code.

Version information

  • Homeserver: dev.t2bot.io
  • Version: 0.30.0
  • Install method: pip
  • Platform: Ubuntu 16.04 VM on ESXi 6.5
@matrixbot matrixbot changed the title Dummy issue Exceptions while parsing EDUs mask the problem area of the source Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant