Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC picture and emails attributes dropped when terms of service is enabled in Synapse #17080

Open
kieranlane opened this issue Apr 12, 2024 · 1 comment

Comments

@kieranlane
Copy link

kieranlane commented Apr 12, 2024

Description

OIDC Emails and Pictures are dropped when terms of service is enabled in Synapse (See relevant log output) so new OIDC users do not have their emails added to their accounts automatically.

Steps to reproduce

  1. Set usermapping:
        user_mapping_provider:
            config:
                email_template: '{{ user.email }}'
  1. Login as a new user, email is not added to account

Homeserver

N/A

Synapse Version

1.104.0

Installation Method

Other (please mention below)

Database

N/A

Workers

I don't know

Platform

EMS 16.70.1

Configuration

user_consent:
require_at_registration: true

Relevant log output

synapse.handlers.sso - 560 - DEBUG - GET-159- Retrieved user attributes from user mapping provider: UserAttributes(localpart='testuser1', confirm_localpart=False, display_name='Test User1', picture='https://i0.wp.com/cdn.auth0.com/avatars/tu.png?ssl=1', emails=['testuser1@example.com']) (attempt 0)

synapse.handlers.sso - 1081 - INFO - GET-164- [session nyBhoMLALAxvvBcP] Registered userid @testuser1:example.com with attributes UserAttributes(localpart='testuser1', confirm_localpart=False, display_name='Test User1, picture=None, emails=())

Anything else that would be useful to know?

No response

@menturion
Copy link

menturion commented May 20, 2024

Same here on Synapse v1.107.

oidc_providers:
  scopes: ["openid", "email", "profile"]
  user_mapping_provider: 
    config:
      picture_template: "{{ user.picture }}"

In my case all mappings work fine with the exception of the user picture. The user pictures are neither added nor updated.
The user consent has never been enabled in homeserver.yaml.

I am running a single Synapse instance (without an external media repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants