Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate thumbnails for Avif images #16897

Open
soupslurpr opened this issue Feb 12, 2024 · 1 comment
Open

Generate thumbnails for Avif images #16897

soupslurpr opened this issue Feb 12, 2024 · 1 comment
Labels
A-Media-Repository A-User-Experience good first issue This is a fix that might be an easy place for someone to start for their first contribution O-Uncommon S-Minor T-Enhancement

Comments

@soupslurpr
Copy link

soupslurpr commented Feb 12, 2024 •
edited
Loading

Description:

Currently, Avif images do not get thumbnails. It would be cool if they did so that I wouldn't have to decode Avif
images specifically instead of just using the thumbnail like I can for other image formats.
@reivilibre reivilibre added A-Media-Repository good first issue This is a fix that might be an easy place for someone to start for their first contribution T-Enhancement A-User-Experience O-Uncommon S-Minor labels May 10, 2024
@reivilibre
Copy link
Contributor

reivilibre commented May 10, 2024 •
edited
Loading

PRs welcome -- This might be as simple as adding the right entry to

synapse/synapse/config/repository.py

Line 57 in 4cf4a82

"image/webp": "jpeg",
, testing it out to make sure it works and ideally adding a small test image to the unit tests (I think we have this for other image formats at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Media-Repository A-User-Experience good first issue This is a fix that might be an easy place for someone to start for their first contribution O-Uncommon S-Minor T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reivilibre @soupslurpr