Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failover_on_unknown_endpoint from /timestamp_to_event after 2023-11-16 #14577

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023

This issue has been migrated from #14577.


Spawning from matrix-org/synapse#14471 (comment) as mentioned by @squahtx,

We can safely remove the following code that was introduced in matrix-org/synapse#14471 when stabilizing the MSC3030 /timestamp_to_event endpoint:

https://github.com/matrix-org/synapse/blob/394d9171b16c481e842dd9cc29f477b0d7a4819a/synapse/federation/federation_client.py#L1694-L1696

After a year, the endpoint will no longer be new and there will be many Synapse versions that include the stabilized endpoint.

It's possible that we leave this check in place though. Maybe we want to handle the case where another homeserver implementation doesn't have it available.

@matrixbot matrixbot changed the title Dummy issue Remove failover_on_unknown_endpoint from /timestamp_to_event after 2023-11-16 Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant