Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventsPersistenceStorageController.persist_event is only used by test code #14039

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments
Open

EventsPersistenceStorageController.persist_event is only used by test code #14039

matrixbot opened this issue Dec 20, 2023 · 0 comments
Labels
O-Uncommon T-Task Z-Cleanup Z-Dev-Wishlist Z-Help-Wanted

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023 •
edited
Loading

This issue has been migrated from #14039.

The following method is only used by test code (albeit extensively): https://github.com/matrix-org/synapse/blob/6caa3030835f879724c003a5b0dc66a6285451d8/synapse/storage/controllers/persist_events.py#L441-L474

Non-test code instead makes use of EventsPersistenceStorageController.persist_events: https://github.com/matrix-org/synapse/blob/6caa3030835f879724c003a5b0dc66a6285451d8/synapse/storage/controllers/persist_events.py#L364-L439

It seems sensible to remove persist_event and migrate the test code to use the plural version of the method instead.
@matrixbot matrixbot changed the title Dummy issue EventsPersistenceStorageController.persist_event is only used by test code Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Uncommon T-Task Z-Cleanup Z-Dev-Wishlist Z-Help-Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot