Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synapse doesn't require new_password on every call to /account/password, contrary to the spec. (But maybe this is a spec oversight?) #13187

Open
matrixbot opened this issue Dec 19, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 19, 2023

This issue has been migrated from #13187.


Link to problem area:

The spec says that new_password is a required field.

new_password string Required: The new password for the account.

However, this endpoint is part of the user-interactive auth stuff, and Synapse only requires you to have provided new_password at least once during a sequence of calls to /account/password. If you've provided a new_password as part of the user-interactive auth, you don't have to provide it with later requests.

This is against the letter of the law as mandated by the spec (but perhaps not the spirit). This might also fall under the category of "user-interactive auth is weird; give us matrix-org/matrix-spec#636 please).

Noticed in #13183.

@matrixbot matrixbot changed the title Dummy issue Synapse doesn't require new_password on every call to /account/password, contrary to the spec. (But maybe this is a spec oversight?) Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant