Fix building debian packages on non-clean checkouts (#17390)

erikjohnston · web-flow · commit 9c8f1a6d412c · 2024-07-02T12:39:32.000+01:00
If we leave the `.so` in place it causes the tests to fail, as it gets
picked up (instead of the newly built .so) and so fails with mismatched
GLIBC errors.
diff --git a/changelog.d/17390.misc b/changelog.d/17390.misc
@@ -0,0 +1 @@
+Fix building debian packages on non-clean checkouts.
diff --git a/docker/build_debian.sh b/docker/build_debian.sh
@@ -11,6 +11,9 @@ DIST=$(cut -d ':' -f2 <<< "${distro:?}")
 cp -aT /synapse/source /synapse/build
 cd /synapse/build
 
+# Delete any existing `.so` files to ensure a clean build.
+rm -f /synapse/build/synapse/*.so
+
 # if this is a prerelease, set the Section accordingly.
 #
 # When the package is later added to the package repo, reprepro will use the

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix building debian packages on non-clean checkouts.`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,9 @@ DIST=$(cut -d ':' -f2 <<< "${distro:?}")`
`11`	`11`	`cp -aT /synapse/source /synapse/build`
`12`	`12`	`cd /synapse/build`
`13`	`13`
	`14`	+# Delete any existing `.so` files to ensure a clean build.
	`15`	`+rm -f /synapse/build/synapse/*.so`
	`16`	`+`
`14`	`17`	`# if this is a prerelease, set the Section accordingly.`
`15`	`18`	`#`
`16`	`19`	`# When the package is later added to the package repo, reprepro will use the`