Skip to content

Commit 3a5bab7

Browse files
committed
Fill in LoggingContext.server_name
1 parent 66aa39f commit 3a5bab7

36 files changed

+216
-117
lines changed

synapse/_scripts/synapse_port_db.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1587,7 +1587,9 @@ def start(stdscr: Optional["curses.window"] = None) -> None:
15871587

15881588
@defer.inlineCallbacks
15891589
def run() -> Generator["defer.Deferred[Any]", Any, None]:
1590-
with LoggingContext(name="synapse_port_db_run"):
1590+
with LoggingContext(
1591+
name="synapse_port_db_run", server_name=config.server.server_name
1592+
):
15911593
yield defer.ensureDeferred(porter.run())
15921594

15931595
reactor.callWhenRunning(run)

synapse/app/admin_cmd.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import os
2525
import sys
2626
import tempfile
27-
from typing import List, Mapping, Optional, Sequence
27+
from typing import List, Mapping, Optional, Sequence, Tuple
2828

2929
from twisted.internet import defer, task
3030

@@ -256,7 +256,7 @@ def finished(self) -> str:
256256
return self.base_directory
257257

258258

259-
def start(config_options: List[str]) -> None:
259+
def load_config(argv_options: List[str]) -> Tuple[HomeServerConfig, argparse.Namespace]:
260260
parser = argparse.ArgumentParser(description="Synapse Admin Command")
261261
HomeServerConfig.add_arguments_to_parser(parser)
262262

@@ -282,11 +282,15 @@ def start(config_options: List[str]) -> None:
282282
export_data_parser.set_defaults(func=export_data_command)
283283

284284
try:
285-
config, args = HomeServerConfig.load_config_with_parser(parser, config_options)
285+
config, args = HomeServerConfig.load_config_with_parser(parser, argv_options)
286286
except ConfigError as e:
287287
sys.stderr.write("\n" + str(e) + "\n")
288288
sys.exit(1)
289289

290+
return config, args
291+
292+
293+
def start(config: HomeServerConfig, args: argparse.Namespace) -> None:
290294
if config.worker.worker_app is not None:
291295
assert config.worker.worker_app == "synapse.app.admin_cmd"
292296

@@ -325,7 +329,7 @@ def start(config_options: List[str]) -> None:
325329
# command.
326330

327331
async def run() -> None:
328-
with LoggingContext(name="command"):
332+
with LoggingContext(name="command", server_name=config.server.server_name):
329333
await _base.start(ss)
330334
await args.func(ss, args)
331335

@@ -337,5 +341,6 @@ async def run() -> None:
337341

338342

339343
if __name__ == "__main__":
340-
with LoggingContext(name="main"):
341-
start(sys.argv[1:])
344+
homeserver_config, args = load_config(sys.argv[1:])
345+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
346+
start(homeserver_config, args)

synapse/app/appservice.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@
2121

2222
import sys
2323

24-
from synapse.app.generic_worker import start
24+
from synapse.app.generic_worker import load_config, start
2525
from synapse.util.logcontext import LoggingContext
2626

2727

2828
def main() -> None:
29-
with LoggingContext(name="main"):
30-
start(sys.argv[1:])
29+
homeserver_config = load_config(sys.argv[1:])
30+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
31+
start(homeserver_config)
3132

3233

3334
if __name__ == "__main__":

synapse/app/client_reader.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@
2121

2222
import sys
2323

24-
from synapse.app.generic_worker import start
24+
from synapse.app.generic_worker import load_config, start
2525
from synapse.util.logcontext import LoggingContext
2626

2727

2828
def main() -> None:
29-
with LoggingContext(name="main"):
30-
start(sys.argv[1:])
29+
homeserver_config = load_config(sys.argv[1:])
30+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
31+
start(homeserver_config)
3132

3233

3334
if __name__ == "__main__":

synapse/app/event_creator.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@
2020

2121
import sys
2222

23-
from synapse.app.generic_worker import start
23+
from synapse.app.generic_worker import load_config, start
2424
from synapse.util.logcontext import LoggingContext
2525

2626

2727
def main() -> None:
28-
with LoggingContext(name="main"):
29-
start(sys.argv[1:])
28+
homeserver_config = load_config(sys.argv[1:])
29+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
30+
start(homeserver_config)
3031

3132

3233
if __name__ == "__main__":

synapse/app/federation_reader.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@
2121

2222
import sys
2323

24-
from synapse.app.generic_worker import start
24+
from synapse.app.generic_worker import load_config, start
2525
from synapse.util.logcontext import LoggingContext
2626

2727

2828
def main() -> None:
29-
with LoggingContext(name="main"):
30-
start(sys.argv[1:])
29+
homeserver_config = load_config(sys.argv[1:])
30+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
31+
start(homeserver_config)
3132

3233

3334
if __name__ == "__main__":

synapse/app/federation_sender.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@
2121

2222
import sys
2323

24-
from synapse.app.generic_worker import start
24+
from synapse.app.generic_worker import load_config, start
2525
from synapse.util.logcontext import LoggingContext
2626

2727

2828
def main() -> None:
29-
with LoggingContext(name="main"):
30-
start(sys.argv[1:])
29+
homeserver_config = load_config(sys.argv[1:])
30+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
31+
start(homeserver_config)
3132

3233

3334
if __name__ == "__main__":

synapse/app/frontend_proxy.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@
2121

2222
import sys
2323

24-
from synapse.app.generic_worker import start
24+
from synapse.app.generic_worker import load_config, start
2525
from synapse.util.logcontext import LoggingContext
2626

2727

2828
def main() -> None:
29-
with LoggingContext(name="main"):
30-
start(sys.argv[1:])
29+
homeserver_config = load_config(sys.argv[1:])
30+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
31+
start(homeserver_config)
3132

3233

3334
if __name__ == "__main__":

synapse/app/generic_worker.py

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -310,13 +310,26 @@ def start_listening(self) -> None:
310310
self.get_replication_command_handler().start_replication(self)
311311

312312

313-
def start(config_options: List[str]) -> None:
313+
def load_config(argv_options: List[str]) -> HomeServerConfig:
314+
"""
315+
Parse the commandline and config files (does not generate config)
316+
317+
Args:
318+
argv_options: The options passed to Synapse. Usually `sys.argv[1:]`.
319+
320+
Returns:
321+
Config object.
322+
"""
314323
try:
315-
config = HomeServerConfig.load_config("Synapse worker", config_options)
324+
config = HomeServerConfig.load_config("Synapse worker", argv_options)
316325
except ConfigError as e:
317326
sys.stderr.write("\n" + str(e) + "\n")
318327
sys.exit(1)
319328

329+
return config
330+
331+
332+
def start(config: HomeServerConfig) -> None:
320333
# For backwards compatibility let any of the old app names.
321334
assert config.worker.worker_app in (
322335
"synapse.app.appservice",
@@ -365,8 +378,9 @@ def start(config_options: List[str]) -> None:
365378

366379

367380
def main() -> None:
368-
with LoggingContext(name="main"):
369-
start(sys.argv[1:])
381+
homeserver_config = load_config(sys.argv[1:])
382+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
383+
start(homeserver_config)
370384

371385

372386
if __name__ == "__main__":

synapse/app/media_repository.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@
2121

2222
import sys
2323

24-
from synapse.app.generic_worker import start
24+
from synapse.app.generic_worker import load_config, start
2525
from synapse.util.logcontext import LoggingContext
2626

2727

2828
def main() -> None:
29-
with LoggingContext(name="main"):
30-
start(sys.argv[1:])
29+
homeserver_config = load_config(sys.argv[1:])
30+
with LoggingContext(name="main", server_name=homeserver_config.server.server_name):
31+
start(homeserver_config)
3132

3233

3334
if __name__ == "__main__":

0 commit comments

Comments
 (0)