Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when loading the configuration file should be easier to read #2491

Open
matrixbot opened this issue Sep 10, 2024 · 0 comments
Open

Errors when loading the configuration file should be easier to read #2491

matrixbot opened this issue Sep 10, 2024 · 0 comments
Labels
A-Configuration Related on what is configurable and how it can be configured

Comments

@matrixbot
Copy link
Collaborator

This issue was originally created by @sandhose at matrix-org/matrix-authentication-service#2491.

Because we use figment to handle configuration, we sometimes have really weird error messages. See #2477 for example.

A few things we should do:

  • avoid #[serde(flatten)], as it breaks error reporting
  • tag important places of the config so that we can
  • do configuration post-processing instead
  • actually test some misconfiguration scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Configuration Related on what is configurable and how it can be configured
Projects
None yet
Development

No branches or pull requests

1 participant