Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large log files (>70Mb) causing rageshake servers to return 403 #1079

Closed
MidhunSureshR opened this issue Apr 27, 2023 · 2 comments · Fixed by #1080
Closed

Fix large log files (>70Mb) causing rageshake servers to return 403 #1079

MidhunSureshR opened this issue Apr 27, 2023 · 2 comments · Fixed by #1080
Assignees

Comments

@MidhunSureshR
Copy link
Member

MidhunSureshR commented Apr 27, 2023

  • Use a dependency to compress the logs before upload. Generally we don't prefer adding dependencies for things like this.
  • Make logging the membership changes optional with a config.
  • Switch over to using open telemetry (but this would not fix the issue)
  • Check if we really need to log all this data (eg: do we need to log all the membership changes? What exactly is a 'membership change'?)
@MidhunSureshR
Copy link
Member Author

Hydrogen will load non terminated calls at startup. Each membership event associated with a call is logged. If a call has a large number of membership events associated with it (say 600), Hydrogen will add 600 log items each time it starts. This is what is inflating the log file.

@MidhunSureshR
Copy link
Member Author

The easy fix is to not log expired members which form the bulk of the logs.

@MidhunSureshR MidhunSureshR linked a pull request May 3, 2023 that will close this issue
@MidhunSureshR MidhunSureshR self-assigned this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant