Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXI silently failed to send message due to unverified devices in a room. #3473

Open
ara4n opened this issue Nov 2, 2024 · 1 comment
Open
Labels
A-E2EE Encryption A-Timeline S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Nov 2, 2024

Steps to reproduce

  1. Send two messages in quick succession in a room where a user has added an unverified device to their account.
  2. First message local echoes (i think) but then the local echo vanishes entirely from the timeline - empirically it never gets sent.
  3. Second message gets the red warning icon, which in turn gives (as expected):

However, the first msg is lost forever.

Outcome

What did you expect?

We should never ever lose messages.

What happened instead?

Presumably there's a race when handling verification state which means that messages sent in quick succession may get lost in the face of unverified devices - or, worse, the first msg sent gets lost whatever.

Your phone model

No response

Operating system version

No response

Application version

747

Homeserver

No response

Will you send logs?

Yes

@ara4n ara4n added T-Defect A-E2EE Encryption S-Critical Prevents work, causes data loss and/or has no workaround A-Timeline labels Nov 2, 2024
@ara4n
Copy link
Member Author

ara4n commented Nov 2, 2024

See also #3006 for a similar failure mode (albeit unrelated to verification pinning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE Encryption A-Timeline S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

No branches or pull requests

1 participant