remove un used code

Author: jesus

libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/floatingvideo/FloatingVideoService.kt

@@ -55,16 +55,14 @@ class FloatingVideoService : Service(), LifecycleOwner, SavedStateRegistryOwner
 
     companion object {
         const val ACTION_START_FLOATING = "START_FLOATING"
-        const val ACTION_STOP_FLOATING = "STOP_FLOATING"
-        const val ACTION_UPDATE_POSITION = "UPDATE_POSITION"
         const val EXTRA_VIDEO_ID = "video_id"
         const val EXTRA_POSITION = "position"
 
         private const val INITIAL_FLOATING_WINDOW_OFFSET_Y = 300
 
         @SuppressLint("ObsoleteSdkInt")
         fun startFloating(
-            context: Context, videoData: MediaViewerPageData.MediaViewerData, position: Long = 0L
+            context: Context, videoId: String, position: Long = 0L
         ) {
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M && !Settings.canDrawOverlays(context)) {
 
@@ -76,13 +74,9 @@ class FloatingVideoService : Service(), LifecycleOwner, SavedStateRegistryOwner
                 return
             }
 
-
-            // Store the video data in repository via DI
-            val videoId = context.bindings<FloatingVideoServiceBindings>().videoDataRepository().storeVideoData(videoData)
-
             val intent = Intent(context, FloatingVideoService::class.java).apply {
                 action = ACTION_START_FLOATING
-                putExtra(EXTRA_VIDEO_ID, videoId)  // Pass only the ID, not the whole object
+                putExtra(EXTRA_VIDEO_ID, videoId)
                 putExtra(EXTRA_POSITION, position)
             }
             context.startService(intent)
@@ -136,21 +130,6 @@ class FloatingVideoService : Service(), LifecycleOwner, SavedStateRegistryOwner
                     }
                 }
             }
-
-            ACTION_STOP_FLOATING -> {
-                // Clean up stored data
-                currentVideoId?.let { videoId ->
-                    videoDataRepository.removeVideoData(videoId)
-                }
-                removeFloatingView()
-                stopSelf()
-            }
-
-            ACTION_UPDATE_POSITION -> {
-                val position = intent.getLongExtra(EXTRA_POSITION, 0L)
-                currentPosition = position
-                videoView?.seekTo(position.toInt())
-            }
         }
         return START_STICKY
     }

libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerNode.kt

@@ -11,10 +11,10 @@ package io.element.android.libraries.mediaviewer.impl.viewer
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.runtime.Composable
-import androidx.compose.runtime.mutableStateOf
-import androidx.compose.runtime.remember
+import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue
+import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalContext
@@ -43,6 +43,7 @@ import io.element.android.libraries.mediaviewer.api.local.LocalMediaFactory
 import io.element.android.libraries.mediaviewer.impl.datasource.FocusedTimelineMediaGalleryDataSourceFactory
 import io.element.android.libraries.mediaviewer.impl.datasource.TimelineMediaGalleryDataSource
 import io.element.android.libraries.mediaviewer.impl.floatingvideo.FloatingVideoService
+import io.element.android.libraries.mediaviewer.impl.floatingvideo.VideoDataRepository
 import io.element.android.libraries.mediaviewer.impl.model.hasEvent
 import io.element.android.services.toolbox.api.systemclock.SystemClock
 
@@ -59,6 +60,7 @@ class MediaViewerNode(
     coroutineDispatchers: CoroutineDispatchers,
     systemClock: SystemClock,
     pagerKeysHandler: PagerKeysHandler,
+    private val videoDataRepository: VideoDataRepository,
     private val textFileViewer: TextFileViewer,
     private val audioFocus: AudioFocus,
     private val sessionId: SessionId,
@@ -145,11 +147,17 @@ class MediaViewerNode(
         ForcedDarkElementTheme(
             colors = colors,
         ) {
-
-//        ForcedDarkElementTheme {
             val state = presenter.present()
             val data = state.listData
                 .getOrNull(state.currentIndex) as? MediaViewerPageData.MediaViewerData
+
+            LaunchedEffect(isMinimized, data) {
+                if ( data != null && isMinimized && data.mediaInfo.mimeType.isMimeTypeVideo() ) {
+                    val videoId = videoDataRepository.storeVideoData(data)
+                    FloatingVideoService.startFloating(context, videoId, 0L)
+                }
+            }
+
             Box(modifier = modifier.fillMaxSize()) {
                 MediaViewerView(
                     state = state,
@@ -159,10 +167,6 @@ class MediaViewerNode(
                     onBackClick = callback::onDone,
                     setMinimize = setMinimized
                 )
-                if (isMinimized && data?.mediaInfo?.mimeType.isMimeTypeVideo() && data != null) {
-
-                    FloatingVideoService.startFloating(context, data, 0L)
-                }
             }
         }
     }