Update settings toggles to use consistent design across app. - #30169
Merged
Merged
Conversation
…gsToggleInput with a warning
4 tasks
…o hs/update-toggles-to-use-consistent-style # Conflicts: # playwright/snapshots/settings/general-room-settings-tab.spec.ts/General-room-settings-tab-should-be-rendered-properly-1-linux.png # playwright/snapshots/settings/notifications/notifications-settings-2-tab.spec.ts/standard-notifications-2-settings-linux.png # playwright/snapshots/settings/room-settings/room-security-tab.spec.ts/room-security-settings-linux.png # playwright/snapshots/settings/room-settings/room-security-tab.spec.ts/room-security-settings-world-readable-linux.png # playwright/snapshots/settings/room-settings/room-video-tab.spec.ts/room-video-settings-linux.png # playwright/snapshots/settings/security-user-settings-tab.spec.ts/security-settings-tab-linux.png
…o hs/update-toggles-to-use-consistent-style
Member
|
Suggesting this skips sonar given most of the untested code is the mostly-unused onSubmit prevent default on the Compound Form Roots which in many cases is not reachable but still worthwhile going forward in case more traditional form elements are used at any point later, and needed to satisfy the type and there are a lot of end to end tests covering these changes. |
t3chguy
approved these changes
Dec 4, 2025
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs element-hq/compound-web#358
This PR effectively changes all the various places we expose a ToggleSwitch (or a handful of places we used a checkbox) to use a standard SettingsToggle switch that always keeps the settings toggle to the left of the label, which provides the best accessibility. This also ensures that all toggles have their descriptions and disabled messages where possible.
This PR is absolutely enormous (sorry!!!!) due to the number of places require to change, so to break the changes down further the following things have been changed:
LabelledToggleSwitchhas been removed in favour of Compound'sSettingsToggleI'd suggest reviewing by checking the code changes first, then jest, then playwright changes in that order which will make the most sense. While the PR is huge, the majority of the trivial changes are component swicheroos or screenshot tests.
Changes areas with screenshot test:
Checklist
public/exportedsymbols have accurate TSDoc documentation.