Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password reset handles Upper Case Characters in email addresses brokenly #9556

Closed
lampholder opened this issue Apr 24, 2019 · 5 comments
Closed
Labels
A-Password-Reset O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@lampholder
Copy link
Member

If your account is linked with example@example.com but you put Example@example.com in the password reset field we tell you we don't know that email address.

@t3chguy
Copy link
Member

t3chguy commented Apr 24, 2019

email addresses are case-sensitive though...
https://stackoverflow.com/questions/9807909/are-email-addresses-case-sensitive

@lampholder
Copy link
Member Author

Oh, huh.

Still, if your account is linked with Example@example.com and you put Example@example.com in the password reset field, we tell you we don't know that email address, too :\

@lampholder lampholder changed the title Password reset doesn't do a case insensitive comparison Password reset handles Upper Case Characters in email addresses brokenly Apr 24, 2019
@lampholder
Copy link
Member Author

So, it looks like we honour case when writing your email address to the database. Then, when it comes to password reset, I think we're comparing whatever address you enter into the password reset UX against the lowercasified email addresses in the database. So, the only way to reset the password for Bob@example.com is to request to reset the password for bob@example.com.

@novocaine novocaine added S-Critical Prevents work, causes data loss and/or has no workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 19, 2021
@kittykat kittykat removed the P1 label Oct 11, 2021
@psrpinto
Copy link
Contributor

psrpinto commented Oct 13, 2021

I can no longer reproduce this issue (Element v1.9.2, synapse v1.44.0).

Password reset works correctly for all the following test cases:


it looks like we honour case when writing your email address to the database.

With synapse, this is no longer the case, I assume since matrix-org/synapse#7021 was merged, we now store the lowered-case email address. In fact, I think we could consider this to be a duplicate of matrix-org/synapse#7016, which was the issue that PR was fixing.

Additionally, MSC2265 is also relevant here, as it implements the following rule:

(...) Strauß@Example.com must be considered as being the same e-mail address as strauss@example.com.

Given the above, I think we can close this issue.

@SimonBrandner
Copy link
Contributor

I agree, if anyone ever sees this again, shout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Password-Reset O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants