Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning matrix username will notify all users with substring display names #8497

Closed
fladd opened this issue Feb 9, 2019 · 12 comments
Closed
Labels
A-Notifications A-Pills P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@fladd
Copy link

fladd commented Feb 9, 2019

Description

If a mentioned matrix username includes a display name, then the user with that display name is also notified. For instance, if I mention "@some.guy.named.matthew:matrix.org", then besides that person, also every other person with a username being "Some", "Guy", "Named", "Matthew", "Matrix" or "Org" gets notified.

Steps to reproduce

  • mention "@some.guy.named.matthew:matrix.org"

Describe how what happens differs from what you expected.
Besides that person, also every other person with a username being "Some", "Guy", "Named", "Matthew", "Matrix" or "Org" gets notified.

Of course only the person with the exact mentioned username "@some.guy.named.matthew:matrix.org" should be notified.

Log: sent/not sent? no

Version information

  • Platform: web (in-browser) or desktop?
    web

For the web app:

  • Browser: Chrome, Safari, Firefox? which version?
    all
  • OS: Windows, macOS, Ubuntu, Arch Linux, etc?
    all
  • URL: riot.im/develop / riot.im/app / somewhere else? If a private server, what version of riot-web?
    develop

For the desktop app:

  • OS: Windows, macOS, Ubuntu, Arch Linux, etc?
    not tested
  • Version: 0.x.y
    not tested
@fladd
Copy link
Author

fladd commented Feb 9, 2019

Apparently this is bug is not unique to matrix IDs. Mentioning "some.guy.named.matthew" will notify the same multiple people, none of which where mentioned explicitly.

@aaronraimist
Copy link
Collaborator

This is by design as far as I know, to support clients that don't create mention "pills"

@fladd
Copy link
Author

fladd commented Feb 10, 2019

Not sure I understand what mention pills have to do with it. The issue I am reporting is that when mentioning a very specific user, with their full matrix user name, other unrelated users get notified as well. I don't think this is intended.

@lampholder
Copy link
Member

Yeah, this doesn't sound like a good end result :\

@lampholder lampholder added T-Defect P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Notifications labels Feb 19, 2019
@SantjagoCorkez
Copy link

A user gets mentioned when just a word in another user's message matches partially one's Matrix ID.

My username is @as:server.name. So when anyone writes a wall of text that will almost always contain the word as (without @-sign) I will be mentioned and notification arises. Make a setting or fix it please.

@t3chguy
Copy link
Member

t3chguy commented Jun 2, 2020

image

it is configurable, you can opt to just have mentions be of your display name and even any custom keywords.

@SantjagoCorkez
Copy link

Which one disables mentioning me by the word as and still allows mentioning with @as?

@t3chguy
Copy link
Member

t3chguy commented Jun 2, 2020

your username is as
You could add a keyword for @as but @as is not a recognized format of anything in Matrix

@SantjagoCorkez
Copy link

Could it be resolved, not workarounded? What if someone mentions by full usernme? That goes deeper and deeper losing mentions here and there. Still to often people use as in their talks to ignore.

@t3chguy
Copy link
Member

t3chguy commented Jun 2, 2020

It'd need to be a conversation for a different project, riot-web is just using the push rules system that Matrix offers it

@jryans jryans added the A-Pills label Jun 23, 2020
@zaibon
Copy link

zaibon commented Dec 23, 2020

I have the same issue. My username is also contained in my homeserver name. So anytime anyone on my server is mention, I'm also mention cause the server name automatically mention me too.
I didn't find any way to workaround this or disable this behavior.

I think mention should not take in subset of a username in account but only a full match. @t3chguy where should we bring this discussion to make it move forward ?

@t3chguy
Copy link
Member

t3chguy commented May 10, 2022

Duplicate of #8431

@t3chguy t3chguy marked this as a duplicate of #8431 May 10, 2022
@t3chguy t3chguy closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Pills P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

7 participants