Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks scroll to the wrong place most of the time. #27507

Open
ara4n opened this issue May 30, 2024 · 1 comment
Open

Permalinks scroll to the wrong place most of the time. #27507

ara4n opened this issue May 30, 2024 · 1 comment
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented May 30, 2024

Steps to reproduce

  1. Click on a permalink (e.g. from a search result)
  2. Get teleported somewhere 2-3 pages above the actual search result
  3. Have to scroll down and find it.

This has been regressed for many months - roughly since the same time as #27312.

Screen.Recording.2024-05-30.at.11.59.28.mov

Outcome

What did you expect?

The highlighted permalink should be shown halfway down the visible window into the timeline.

What happened instead?

The scroll offset behaves as if there's been a massive scroll jump; the permalink is anywhere from 1 to 3 pages off the bottom of the page. (Or sometimes above it).

Operating system

No response

Application version

Element Nightly version: 2024053001 Crypto version: Rust SDK 0.7.0 (068a0af), Vodozemac 0.6.0

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label May 30, 2024
@ara4n ara4n changed the title Permalinks don't work reliably most of the time. Permalinks scroll to the wrong place most of the time. May 30, 2024
@dosubot dosubot bot added A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 30, 2024
@ara4n
Copy link
Member Author

ara4n commented May 30, 2024

(n.b. this is much worse than #2150 was - where you could literally see the permalink get moved off the screen as images loaded. here instead we appear to be loading the room in entirely the wrong place, as if a scrolljump had happened)

Actually, stepping frame by frame through the video, it does load the permalink at first in entirely the right place, and then about 2 frames later it does a massive scrolljump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

2 participants