Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji are small again #26401

Closed
robintown opened this issue Oct 18, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11774
Closed

Emoji are small again #26401

robintown opened this issue Oct 18, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11774
Assignees
Labels
A11y A-Composer A-Emoji A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Look at a message with emoji, either in the composer or the timeline

Outcome

What did you expect?

Emoji should have a larger font size than the surrounding text

What happened instead?

Emoji are given the same font size as the surrounding text

Operating system

NixOS unstable

Browser information

Firefox 118.0.1

URL for webapp

develop.element.io

Application version

Element version: f1a39b3-react-eb7ce666b748-js-4bcea2cead97 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No

@robintown robintown added T-Defect X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline A-Composer A-Emoji A11y O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 18, 2023
@t3chguy
Copy link
Member

t3chguy commented Oct 19, 2023

Regressed by matrix-org/matrix-react-sdk#11757

@HarHarLinks
Copy link
Contributor

Emoji should have a larger font size than the surrounding text

Does this rule also apply to the topic in the new room header? If so, matrix-org/matrix-react-sdk#11757 can be reverted entirely and another solution that instead adjusts new room header layout is required.

@Johennes
Copy link
Contributor

Johennes commented Oct 19, 2023

Adding this to the A11y/Compound board view. @kerryarchibald maybe you could give this a look on the back of the PR mentioned above? It might also be good to verify whether we have Percy tests to cover this.

@kerryarchibald
Copy link
Contributor

Reverting matrix-org/matrix-react-sdk#11774 and reopening #26326

Should have tested more carefully, I thought inline emojis being the same size as the text looked correct. Percy tests would have caught this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-Composer A-Emoji A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
5 participants