Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter avatars are all grey #26042

Closed
weeman1337 opened this issue Aug 24, 2023 · 12 comments Β· Fixed by matrix-org/matrix-react-sdk#11470
Closed

Letter avatars are all grey #26042

weeman1337 opened this issue Aug 24, 2023 · 12 comments Β· Fixed by matrix-org/matrix-react-sdk#11470
Assignees
Labels
A11y A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@weeman1337
Copy link
Contributor

Steps to reproduce

  1. Open current develop https://develop.element.io/
  2. Look at the avatars

Outcome

What did you expect?

Colours πŸ–ŒοΈ

What happened instead?

They are all grey 😐

image

Operating system

Ubuntu 22.04.3 LTS

Browser information

Firefox 117.0

URL for webapp

https://develop.element.io/

Application version

Version von Element: 780da23-react-09c5e06d12ac-js-c5245a887b67 Version von Olm: 3.2.14

Homeserver

matrix.org

Will you send logs?

No

@weeman1337 weeman1337 added T-Defect X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 24, 2023
@MTRNord
Copy link
Contributor

MTRNord commented Aug 24, 2023

This happens for me too on darkmode :)

In version: Version von Element: 780da23-react-9fb7d94c2bc8-js-c5245a887b67
Version von Olm: 3.2.14

@MTRNord
Copy link
Contributor

MTRNord commented Aug 24, 2023

It seems like the variable exists but the bg css not
image

@germain-gg
Copy link
Contributor

This is really strange, things load perfectly fine on my develop.element.io , both for light and dark theme.

Screenshot 2023-08-24 at 14 09 05

@MTRNord
Copy link
Contributor

MTRNord commented Aug 24, 2023

That smells like a caching issue potentially? In the past this happened with the language files which is why they had a cachebuster hash attached. Not sure however if that even does something these days still

Edit: Even after forcefully removing the page cache and reloading this bug remains.

@germain-gg
Copy link
Contributor

Not really, because the design tokens are included in there from the day where Element started using the new colour set.

In here, something makes them either not being applied, but i am yet to figure out what triggers this, continuing the conversation in https://matrix.to/#/#element-dev:matrix.org

@germain-gg germain-gg self-assigned this Aug 24, 2023
@germain-gg germain-gg added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 24, 2023
@plui29989
Copy link

Hi,
avatar letters are still grey for me - only in firefox though. Other browsers (Safari, Chrome) seem to be unaffected.
I'm using
Element-Web 1.11.41
Firefox 117.0

@ftyers
Copy link

ftyers commented Sep 12, 2023

I'm running 1.11.41 too and it's the same in Firefox.

imatge

@DoruDoLasu
Copy link

yep, just updated. on firefox. not only the username colours look worse (imo) but also that

@ManuelHu
Copy link

Just some investigation I just did:
Toggling layout.css.has-selector.enabled in Firefox's about:config "fixes" the issue. Firefox is currently the only mainstream browser not supporting the CSS :has() selector.

And this selector is used to style the avatar in element 1.11.41.

This has been fixed in element-hq/compound-web@1361a4a, but apparently did not make it into the release :-/

@ftyers
Copy link

ftyers commented Sep 12, 2023

@ManuelHu Thanks! I tried enabling that but it still looks the same. I also tried force-refreshing. Isn't it the only browser that isn't based on Chromium too? Any idea of when the next release will be (that will include that fix) ?

@ManuelHu
Copy link

I am using the beta version of Firefox (118) and there just toggling the pref in about:config and force-reloading Element shows colored avatars.
But anyway, the real fix is in the compound repo, the above was just for testing (it probably has some reasons that the firefox setting is off by default...)

I am not following the Element development closely, but on the develop branch the compound fix is already available.

@t3chguy
Copy link
Member

t3chguy commented Sep 12, 2023

Tracked in #26155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants