Skip to content

Room scroll state is broken #25810

@greentore

Description

@greentore

Steps to reproduce

Since v1.11.25 of Element (matrix-react-sdk v3.68.0) the scroll state of rooms isn't saved.
Seems like the issue is localized in src/components/structures/RoomView.tsx and caused by this.state.roomId being initialized to undefined instead of null and therefore failing a strict check at line 746.

Steps to reproduce

  1. Open any room and scroll up
  2. Open some other room
  3. Go back the the first room

Outcome

What did you expect?

The scroll state is restored.

What happened instead?

I see the bottom of the room.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

Metadata

Metadata

Assignees

Labels

O-OccasionalAffects or can be seen by some users regularly or most users rarelyS-MajorSeverely degrades major functionality or product features, with no satisfactory workaroundT-DefectX-Regression

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions