Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Manually verify by text" does nothing #25375

Closed
MadLittleMods opened this issue May 15, 2023 · 12 comments · Fixed by matrix-org/matrix-react-sdk#11059
Closed

"Manually verify by text" does nothing #25375

MadLittleMods opened this issue May 15, 2023 · 12 comments · Fixed by matrix-org/matrix-react-sdk#11059
Assignees
Labels
A-E2EE-Cross-Signing A-Session-Mgmt Session / device names, management UI, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented May 15, 2023

Steps to reproduce

  1. Click on your avatar in the timeline of some room which will open your profile on the right side of the screen
  2. In the Security section you should be able to click on your Hydrogen session
  3. Click "Manually Verify by Text"
  4. Make sure the Session ID and Session key match what is shown in the Hydrogen settings
  5. Click the green Verify session button which
  6. Notice that nothing seemed to happen except that the dialog was dismissed. The session still shows as unverified and going through the process over again has no effect.
1 2 3 4

(it's only possible to verify by text via the steps above because it's not in the session manager, see #20273)

Outcome

What did you expect?

My session would be become verified after I manually verified it. This used to work just fine.

It did work as expected when I tried from another Element Desktop session.

What happened instead?

No change and my sessions are still unverified. I don't even see a network request going out.

Operating system

Manjaro Linux 22.1.1 (Arch-based)

Browser information

Version 113.0.5672.92

URL for webapp

https://develop.element.io/

Application version

Element version: 88c5395-react-38c13509fd21-js-43160094019a Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

Yes

@MadLittleMods MadLittleMods added T-Defect A-Session-Mgmt Session / device names, management UI, etc. labels May 15, 2023
@luixxiul
Copy link

I think I noticed the same issue when I tried to verify a session of Hydrogen.

@andybalaam andybalaam added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels May 23, 2023
@dt-zero
Copy link

dt-zero commented Jun 2, 2023

For anybody wondering, a temporary workaround can be to start a local instance of an older element-web version, e.g. sudo docker run --rm -p 80:80 vectorim/element-web:v1.11.13 and verify through that. I didn't bisect but I imagine this regressed at some point between that and current master. (as the bug also reproduces on the latest master version at the time of writing 945c079)

@kerryarchibald
Copy link
Contributor

Regressed by matrix-org/matrix-react-sdk#10671

@MadLittleMods
Copy link
Contributor Author

Thanks for investigating and fixing @kerryarchibald 🙂

@dannysemi
Copy link

Pretty sure this has regressed again. Trying to "manually verify by text" doesn't do anything when I click the button in the web ui. It doesn't even dismiss the message. I loaded up an older image (1.11.55) and it worked just fine.

su-ex added a commit to SchildiChat/element-web that referenced this issue Feb 22, 2024
* OIDC: add delegatedauthentication to validated server config ([\element-hq#11053](matrix-org/matrix-react-sdk#11053)). Contributed by @kerryarchibald.
* Allow image pasting in plain mode in RTE ([\element-hq#11056](matrix-org/matrix-react-sdk#11056)). Contributed by @alunturner.
* Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\element-hq#10365](matrix-org/matrix-react-sdk#10365)). Contributed by @maheichyk.
* Allow image pasting in rich text mode in RTE ([\element-hq#11049](matrix-org/matrix-react-sdk#11049)). Contributed by @alunturner.
* Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\element-hq#11014](matrix-org/matrix-react-sdk#11014)). Fixes element-hq#25471.
* Add config to skip widget_build_url for DM rooms ([\element-hq#11044](matrix-org/matrix-react-sdk#11044)). Fixes vector-im/customer-retainer#74.
* Inhibit interactions on forward dialog message previews ([\element-hq#11025](matrix-org/matrix-react-sdk#11025)). Fixes element-hq#23459.
* Removed `DecryptionFailureBar.tsx` ([\element-hq#11027](matrix-org/matrix-react-sdk#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros.
* Fix translucent `TextualEvent` on search results panel ([\element-hq#10810](matrix-org/matrix-react-sdk#10810)). Fixes element-hq#25292. Contributed by @luixxiul.
* Matrix matrix scheme permalink constructor not stripping query params ([\element-hq#11060](matrix-org/matrix-react-sdk#11060)). Fixes element-hq#25535.
* Fix: "manually verify by text" does nothing ([\element-hq#11059](matrix-org/matrix-react-sdk#11059)). Fixes element-hq#25375. Contributed by @kerryarchibald.
* Make group calls respect the ICE fallback setting ([\element-hq#11047](matrix-org/matrix-react-sdk#11047)). Fixes vector-im/voip-internal#65.
* Align list items on the tooltip to the start ([\element-hq#11041](matrix-org/matrix-react-sdk#11041)). Fixes element-hq#25355. Contributed by @luixxiul.
* Clear thread panel event permalink when changing rooms ([\element-hq#11024](matrix-org/matrix-react-sdk#11024)). Fixes element-hq#25484.
* Fix spinner placement on pinned widgets being reloaded ([\element-hq#10970](matrix-org/matrix-react-sdk#10970)). Fixes element-hq#25431. Contributed by @luixxiul.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Feb 22, 2024
* OIDC: add delegatedauthentication to validated server config ([\matrix-org#11053](matrix-org#11053)). Contributed by @kerryarchibald.
* Allow image pasting in plain mode in RTE ([\matrix-org#11056](matrix-org#11056)). Contributed by @alunturner.
* Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\matrix-org#10365](matrix-org#10365)). Contributed by @maheichyk.
* Allow image pasting in rich text mode in RTE ([\matrix-org#11049](matrix-org#11049)). Contributed by @alunturner.
* Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\matrix-org#11014](matrix-org#11014)). Fixes element-hq/element-web#25471.
* Add config to skip widget_build_url for DM rooms ([\matrix-org#11044](matrix-org#11044)). Fixes vector-im/customer-retainer#74.
* Inhibit interactions on forward dialog message previews ([\matrix-org#11025](matrix-org#11025)). Fixes element-hq/element-web#23459.
* Removed `DecryptionFailureBar.tsx` ([\matrix-org#11027](matrix-org#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros.
* Fix translucent `TextualEvent` on search results panel ([\matrix-org#10810](matrix-org#10810)). Fixes element-hq/element-web#25292. Contributed by @luixxiul.
* Matrix matrix scheme permalink constructor not stripping query params ([\matrix-org#11060](matrix-org#11060)). Fixes element-hq/element-web#25535.
* Fix: "manually verify by text" does nothing ([\matrix-org#11059](matrix-org#11059)). Fixes element-hq/element-web#25375. Contributed by @kerryarchibald.
* Make group calls respect the ICE fallback setting ([\matrix-org#11047](matrix-org#11047)). Fixes vector-im/voip-internal#65.
* Align list items on the tooltip to the start ([\matrix-org#11041](matrix-org#11041)). Fixes element-hq/element-web#25355. Contributed by @luixxiul.
* Clear thread panel event permalink when changing rooms ([\matrix-org#11024](matrix-org#11024)). Fixes element-hq/element-web#25484.
* Fix spinner placement on pinned widgets being reloaded ([\matrix-org#10970](matrix-org#10970)). Fixes element-hq/element-web#25431. Contributed by @luixxiul.
@MrConorAE
Copy link

MrConorAE commented Mar 9, 2024

Yep, it's definitely regressed. Trying to click it prints this message to the console, if that helps:

17:32:33.039 Uncaught Error: End-to-end encryption disabled
    checkKeyBackup (client.ts:3385)
    setDeviceVerified (client.ts:2496)
    i (ManualDeviceKeyVerificationDialog.tsx:45)
    d (QuestionDialog.tsx:54)
    > React [11]
    unstable_runWithPriority (scheduler.production.min.js:18)
    > React [3]
17:32:33.045 Uncaught (in promise) Error: End-to-end encryption disabled
    setDeviceVerification (client.ts:2547)
    setDeviceVerified (client.ts:2490)
    i (ManualDeviceKeyVerificationDialog.tsx:45)
    d (QuestionDialog.tsx:54)
    > React [11]
    unstable_runWithPriority (scheduler.production.min.js:18)
    > React [3]

@kr428
Copy link

kr428 commented Apr 11, 2024

This seems still an issue I see. Is there any way to work around this, currently?

@worldowner
Copy link

Shouldn't this issue be re-opened? Clearly the issue reappeared.

@t3chguy
Copy link
Member

t3chguy commented May 13, 2024

@worldowner #27201

It doesn't work for an entirely different issue, so no shouldn't be reopened.

@worldowner
Copy link

Thank you for clarification. I didn't encounter the issue you've mentioned when I was browsing bug reports.

@F-Node-Karlsruhe
Copy link

This issue started for us when we enabled SSO on the matrix server with oidc.

@Cnly
Copy link

Cnly commented Sep 25, 2024

Still seeing this with Element Nightly. Currently there seems to be no way to verify a device controlled by Maubot. This issue should be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing A-Session-Mgmt Session / device names, management UI, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.