Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle room list updates properly with manual sort #25184

Open
kerryarchibald opened this issue Apr 23, 2023 · 0 comments
Open

Handle room list updates properly with manual sort #25184

kerryarchibald opened this issue Apr 23, 2023 · 0 comments
Labels
A-Developer-Experience A-Room-List A-Testing Testing, code coverage, etc. Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely T-Defect

Comments

@kerryarchibald
Copy link
Contributor

kerryarchibald commented Apr 23, 2023 •
edited
Loading

Testing ImportanceAlgorithm showed that room updates are not handled properly for manual sorting and raise errors.
Skipped tests here:
https://github.com/matrix-org/matrix-react-sdk/blob/1440e347ea17a1f17ccefce3b9390fadacb3d5f7/test/stores/room-list/algorithms/list-ordering/ImportanceAlgorithm-test.ts#L95
@kerryarchibald kerryarchibald added T-Defect A-Room-List A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 23, 2023
@Johennes Johennes added A-Testing Testing, code coverage, etc. Help Wanted Extra attention is needed Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience A-Room-List A-Testing Testing, code coverage, etc. Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Johennes @kerryarchibald