Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gfm.css is no longer supported #24694

Closed
t3chguy opened this issue Feb 28, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#12613
Closed

gfm.css is no longer supported #24694

t3chguy opened this issue Feb 28, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#12613
Assignees
@t3chguy
Labels
A-Developer-Experience Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed T-Task Tasks for the team like planning

Comments

@t3chguy
Copy link
Member

t3chguy commented Feb 28, 2023

warning gfm.css@1.1.2: Package no longer supported. Please use github-markdown-css instead.
@MadLittleMods MadLittleMods added the T-Task Tasks for the team like planning label Mar 15, 2023
@t3chguy
Copy link
Member Author

t3chguy commented Apr 25, 2023

This brings visual changes

Before
image

After
image

Likely to be delegated to Compound

@Johennes
Copy link
Contributor

@nadonomy how do you feel about us going ahead with this for now? It'll be a while until we get to touching the timeline as part of the Compound adoption work and would be nice to eliminate the unsupported dependency in the meantime.

@nadonomy
Copy link
Contributor

Wfm. We can catch any nasty unintended consequences on develop.

@Johennes Johennes added Help Wanted Extra attention is needed Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ labels Oct 24, 2023
@t3chguy t3chguy self-assigned this Jun 13, 2024
This was referenced Jun 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Developer-Experience Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gfm.css to github-markdown-css matrix-org/matrix-react-sdk
5 participants
@MadLittleMods @Johennes @t3chguy @florianduros @nadonomy