Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll position of main timeline is reset when opening thread #24379

Open
MadLittleMods opened this issue Jan 30, 2023 · 2 comments
Open

Scroll position of main timeline is reset when opening thread #24379

MadLittleMods opened this issue Jan 30, 2023 · 2 comments
Labels
A-Threads A-Timeline A-Timeline-Jumpy-Scroll Stable timeline dream ✨ S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Jan 30, 2023

Steps to reproduce

  1. Jump back in the room history catching up on messages
  2. Open a thread you stumble upon while catching up
  3. Main timeline scroll position is jumped to the bottom (showing latest messages) ❌

Outcome

What did you expect?

The main timeline should maintain whatever scroll I was at before opening the thread

What happened instead?

The main timeline scroll position is jumped to the bottom (showing latest messages) ❌

Operating system

Windows 10

Browser information

Chrome Version 109.0.5414.120

URL for webapp

https://develop.element.io/

Application version

Element version: 50f2b53-react-4c1e4f5127bd-js-4f918f684e9d Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes, https://github.com/matrix-org/element-web-rageshakes/issues/19796

@SimonBrandner SimonBrandner added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 31, 2023
@SimonBrandner
Copy link
Contributor

I can't repro, sadly

@MadLittleMods
Copy link
Contributor Author

MadLittleMods commented Jan 31, 2023

We should really have debug logs that include enough information to be able to figure out whenever and why this kind of thing happens. We should log when a thread is opened and closed because at the very least it's a good point of reference to read from in the logs. Whenever we update the scroll position or reset a timeline, there should be a paper trail to know what triggered it. What made the unread marker appear and disappear, etc (Room was marked unread because event $xxx is in front of unread marker m.read $xxx). Update: Related to #24388

These timeline problems are very annoying and reports are fruitless because these things aren't consistently reproducible and there is no information in the logs to help reproduce later with.

@germain-gg germain-gg added the A-Timeline-Jumpy-Scroll Stable timeline dream ✨ label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads A-Timeline A-Timeline-Jumpy-Scroll Stable timeline dream ✨ S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce
Projects
None yet
Development

No branches or pull requests

3 participants