Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the voice broadcast chunks at the notifications level #24101

Closed
giomfo opened this issue Dec 23, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9852
Closed
Labels
A-Broadcast Broadcast-style voice messages A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@giomfo
Copy link
Member

giomfo commented Dec 23, 2022

Your use case

What would you like to do?

During the notifications handling, we should ignore events related to the voice broadcast chunks

Why would you like to do it?

These events are not displayed in the room timeline, they should not be taken into account in the notifications count.
They are voice messages marked as voice broadcast chunks (they refer to a voice message state event)

There is no case where the user may want to be notified on these chunks, they are supposed to be invisible for them. That is why we can hardcode this mechanism client side without adding config in push rules

How would you like to achieve it?

We have to ignore them locally, because these events are encrypted, we could not ignore them server side

Have you considered any alternatives?

No response

Additional context

No response

@giomfo giomfo added T-Enhancement A-Broadcast Broadcast-style voice messages labels Dec 23, 2022
@SimonBrandner
Copy link
Contributor

Sounds like element-hq/element-meta#1001 ?

@SimonBrandner SimonBrandner added X-Needs-Info This issue is blocked awaiting information from the reporter A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Broadcast Broadcast-style voice messages A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants