Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect collapsed event summary for user who got banned as they joined a room #23588

Open
babolivier opened this issue Oct 25, 2022 · 0 comments
Open

Incorrect collapsed event summary for user who got banned as they joined a room #23588

babolivier opened this issue Oct 25, 2022 · 0 comments
Labels
A-ELS Event List Summary (and Membership ELS, MELS) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@babolivier
Copy link
Contributor

babolivier commented Oct 25, 2022 •
edited
Loading

Steps to reproduce

Steps from the infringing user:

  1. Get added to a mjolnir ban list
  2. Enter a room guarded by mjolnir after being added to the ban list
  3. Get banned from the room by mjolnir

From my point of view:

  1. View the room
  2. Expand collapsed events
  3. Compare events with summary display when collapsed

Outcome

What did you expect?

The summary should say something like "[user] joined the room and was banned".

What happened instead?

The summary says "[user] removed a message and was banned"

Peek.2022-10-25.11-53.mp4

The event with the wrong summary is https://matrix.to/#/!UBhRLVEYYvUWnsljRs:matrix.org/$V6TfYuAsHt1W1FUFfk8oN0EBVaZs_D_VUw1kXxcfTqk?via=matrix.org&via=tchncs.de&via=envs.net

Operating system

Arch Linux

Browser information

Firefox 105.0.1

URL for webapp

develop.element.io

Application version

Element version: fc0e61b-react-6e73a853a8c7-js-9bdeea0a8d0b, Olm version: 3.2.12

Homeserver

element.io

Will you send logs?

Yes
@babolivier babolivier changed the title Incorrect collapsed event summary for user that got banned as they joined a room Incorrect collapsed event summary for user who got banned as they joined a room Oct 25, 2022
@kerryarchibald kerryarchibald added A-Timeline A-ELS Event List Summary (and Membership ELS, MELS) S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely and removed A-Timeline labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ELS Event List Summary (and Membership ELS, MELS) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kerryarchibald @babolivier