Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-request encryption keys prompt remains after message is decrypted #23550

Closed
andybalaam opened this issue Oct 19, 2022 · 6 comments
Closed
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect

Comments

@andybalaam
Copy link
Contributor

Steps to reproduce

  1. Receive a message where there is a delay receiving the encryptions keys, so an error is displayed
  2. Wait, and see the message get decrypted
  3. Note that the "Re-request encryption keys" text is still there.

image

Outcome

What did you expect?

I expected this prompt to disappear because the message was decrypted, and it is now just confusing.

What happened instead?

It stayed around.

Operating system

Ubuntu 22.04

Browser information

Firefox 105.0.2

URL for webapp

https://develop.element.io

Application version

Element version: 921deab-react-e0ab0ac5c999-js-17e16b9b1a4d Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes

@uhoreg uhoreg added S-Tolerable Low/no impact on users A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 19, 2022
@buffless-matt
Copy link

I'm experiencing the same thing, but with a mixture of horizontal (as shown in Andy's screenshot) and vertical text:

image

Operating system

Ubuntu 20.04

Application version

Element desktop version: 1.11.10

@andybalaam
Copy link
Contributor Author

I am seeing this regularly now. I have several instances in a single room.

@andybalaam andybalaam added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 21, 2022
@andybalaam
Copy link
Contributor Author

@uhoreg I bumped this up to O-Frequent - please change it if you disagree.

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Oct 21, 2022

Step to reprocude

  1. Send a message In a room with some history => the intitial sync has to be limited=truefor that room

  2. Edit it once

  3. Do a clear cache (initial sync)

=> Now you have the problem

I am getting back a message with empty content, like a it's doing for redact?

{
  "type": "m.room.encrypted",
  "sender": "@alice:localhost:8480",
  "content": {},
  "origin_server_ts": 1666342304414,
  "unsigned": {
    "age": 500276,
    "transaction_id": "m1666342304366.6",
    "m.relations": {
      "m.replace": {
        "event_id": "$toxW3soIUzZbG6cmnw94p0-cvQ5_AlIM0NJ7SJz7vpY",
        "origin_server_ts": 1666342320779,
        "sender": "@alice:localhost:8480"
      }
    }
  },
  "event_id": "$q6rQxsGaW0XscWvlnTUiWVIAcV07AMNZqZzPF3Sbga4"
}

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Oct 21, 2022

Before & after initial sync:
(original event is b51iVve9PasAMiwPAS697t2AtcKjcpeqfRZhbo28dmU and edit is $b51iVve9PasAMiwPAS697t2AtcKjcpeqfRZhbo28dmU)

Before (from timeline view source)

{
  "type": "m.room.encrypted",
  "sender": "@alice:localhost:8480",
  "content": {
    "algorithm": "m.megolm.v1.aes-sha2",
    "sender_key": "hGKn1DTWmQF6fkJY4uUUrlLBubyt9DHyQkbLSeuE+xU",
    "ciphertext": "AwgAEqAB+c+86+ViMDxn17VY+9W3mJPEEOwsvCgtN/kglMLAuvcak8ldhU+lNb6PqT1/foNfRpBlMb7/GbQEJ1NkbDGKyj+9N6nl/o4J28hSOavTJZcuRq74BA3Lb4mi5ntJs7l5cKxhBj/sTUSzMcxpM9NsxtZNL5sI/emObWbD2+nfCg2jytlKZqM+Cesj2pgDrSu9Vqb8+VbX5OTrDr4KzlVOPpA2rGU3ufbBj8M8uUNlUbzRWChhNEQ2rnjKDPnrzQO8wTYVt7uq+kr9SZzwb5xWNyOcXFH0c1Ec6npPbvdb3jf50AjQTV5GBg",
    "session_id": "KQrjVvG9p7kLCThUTWRIxk66Znr9isRjSTxwLOc99c0",
    "device_id": "QCBCOIBBFJ"
  },
  "origin_server_ts": 1666343360659,
  "unsigned": {
    "age": 74,
    "transaction_id": "m1666343360614.4"
  },
  "event_id": "$b51iVve9PasAMiwPAS697t2AtcKjcpeqfRZhbo28dmU",
  "room_id": "!tWvKYbGyhxZIROGqGa:localhost:8480"
}

After (from the sync request)

{
  "type": "m.room.encrypted",
  "sender": "@alice:localhost:8480",
  "content": {},
  "origin_server_ts": 1666343360659,
  "unsigned": {
    "age": 31245,
    "transaction_id": "m1666343360614.4",
    "m.relations": {
      "m.replace": {
        "event_id": "$k9aKiHCMFZ-yxvfxfIwEIT5o4kR3ul5CdEVUV9LcJ0w",
        "origin_server_ts": 1666343381454,
        "sender": "@alice:localhost:8480"
      }
    }
  },
  "event_id": "$b51iVve9PasAMiwPAS697t2AtcKjcpeqfRZhbo28dmU"
}

And here is the edit event:

{
  "type": "m.room.encrypted",
  "sender": "@alice:localhost:8480",
  "content": {
    "algorithm": "m.megolm.v1.aes-sha2",
    "sender_key": "hGKn1DTWmQF6fkJY4uUUrlLBubyt9DHyQkbLSeuE+xU",
    "ciphertext": "AwgBEoACcb5hO+mcG2xGQksn2J5RRAaO8BT4bCNpPXT+V0rhCKgbMQAdnHpht2jxWtHjiVrfwFBxJfKSCXdNG1L1hmw1SHs/AzdT41a1S+UHQf01mAl7WI/bhhsWdtPQiLzZPg3MkDhws+V6bhudTpJdkQ6S0ekOlkLMdbbFVCMR6bBfdSSSVy0AI2IvhcQrjjVVBpI6VtU9s/DAApcQKHpOAIXIju/VFSzCzoDs537jiyUGPAlfH2ECdBudtMopqRqTsmHK2/kujYZex+kpBbHl7F8QAqG2HeZcyjaYDhpfwf3smPSucXcNtUGNtFR484bm0Cpb3xAc7sU2JC3SHYxbSLBrCMOxc4djpt4PasDm0YXDQn9306jGpaKAo/792Zvw7nKpWJD4vMdrZGz0n1x50BZUb73vOsUNwlePsjEuzv1B2ozZ7rAxeMSLCQ",
    "session_id": "KQrjVvG9p7kLCThUTWRIxk66Znr9isRjSTxwLOc99c0",
    "device_id": "QCBCOIBBFJ",
    "m.relates_to": {
      "rel_type": "m.replace",
      "event_id": "$b51iVve9PasAMiwPAS697t2AtcKjcpeqfRZhbo28dmU"
    }
  },
  "origin_server_ts": 1666343381454,
  "unsigned": {
    "age": 10450,
    "transaction_id": "m1666343381426.5"
  },
  "event_id": "$k9aKiHCMFZ-yxvfxfIwEIT5o4kR3ul5CdEVUV9LcJ0w"
}

@BillCarsonFr
Copy link
Member

Root cause matrix-org/synapse#14252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants