polls/polls.spec.ts → „displays polls correctly in thread panel“ failing

[weeman1337]

Steps to reproduce

Sample run https://dashboard.cypress.io/projects/ppvnzg/runs/4745/test-results/a427ea69-0e52-4d77-9c8c-0393929e99d7

Logs:

M_INVALID_PARAM

The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.

  > event_id $TylyWHJ9CdnaeQGibCRZKwG9ClkEoL63ZG4XTjS5iQU is not related to thread $0dX0Jz71z_UbtRRgrzObk0tRl6djOFMNgpNUfU1yH40

When Cypress detects uncaught errors originating from your application it will automatically fail the current test.

This behavior is configurable, and you can choose to turn this off by listening to the uncaught:exception event.

https://on.cypress.io/uncaught-exception-from-application

at parseErrorResponse (http://localhost:8080/bundles/cc8b528ed0970d448730/init.js:59888:13) at http://localhost:8080/bundles/cc8b528ed0970d448730/init.js:59838:17 at Object.callback (http://localhost:8080/bundles/cc8b528ed0970d448730/init.js:59762:9) at on_end (http://localhost:8080/bundles/cc8b528ed0970d448730/vendors~element-web-app.js:294:13) at XMLHttpRequest.on_state_change (http://localhost:8080/bundles/cc8b528ed0970d448730/vendors~element-web-app.js:244:7) at XMLHttpRequest.<anonymous> (http://localhost:8080/bundles/cc8b528ed0970d448730/vendors~init.js:203360:41) at XMLHttpRequest.eval (eval at makeContentWindowListener (http://localhost:8080/__cypress/runner/cypress_runner.js:171203:10), <anonymous>:4:29)

Screenshot

[germain-gg]

Delight will take on this 🖐️

[t3chguy]

Related https://github.com/matrix-org/synapse/blame/1bf2832714abdfc5e10395e8e76aecc591ad265f/synapse/rest/client/versions.py#L108

[germain-gg]

Synapse returns a 400 with an errcode M_INVALID_PARAM because the timeline code is trying to send a read receipt with a thread id param for a poll answer to the thread root.

If you traverse the relations of that poll answer it will lead you to the thread root that does not hold a m.thread relation, therefore the read receipt endpoint will fail.

We have two ways of solving this issue, either adding another codepath client side to prevent sending RR with thread id for relations to the thread root in a thread timeline (poll answers, annotation to the thread root, ...) or we make the API endpoint more flexible and accept that as an incoming request.

[germain-gg]

This is pending changes on synapse that @clokep will do to accept that scenario.
If that is too cumbersome to implement on the server, clients will do some of the heavy lifting

[clokep]

matrix-org/synapse#14168 should fix the synapse behavior here.

[clokep]

This should be fixed on the latest synapse.

[t3chguy]

Confirmed fixed by matrix-org/matrix-react-sdk@13e9e14 passing