Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta-issue for Sliding Sync TODO comments #23207

Open
kegsay opened this issue Sep 5, 2022 · 0 comments
Open

Meta-issue for Sliding Sync TODO comments #23207

kegsay opened this issue Sep 5, 2022 · 0 comments
Labels
A-Sliding-Sync Also known as Sync v3 - https://github.com/matrix-org/sliding-sync O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement

Comments

@kegsay
Copy link
Contributor

kegsay commented Sep 5, 2022

Your use case

This is current as of c2598aa on matrix-org/matrix-react-sdk#8328

  • SlidingRoomListStore.setListOrder is not implemented. Therefore, the flag Show rooms with unread messages first does nothing in Sliding Sync mode.
  • Sliding Sync mode does not implement the function doesRoomHaveUnreadMessages - meaning there are no unread indicators in Sliding Sync mode yet.
  • Sliding Sync mode does not implement lists for DefaultTagID.ServerNotice, DefaultTagID.Suggested, DefaultTagID.Archived or DefaultTagID.SavedItems yet. Therefore, these lists will be missing entirely in sliding sync mode, even if there are rooms that would go into these lists.

Have you considered any alternatives?

No response

Additional context

No response
@kegsay kegsay mentioned this issue Sep 5, 2022
Merged
@duxovni duxovni added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Sep 9, 2022
@MadLittleMods MadLittleMods added the A-Sliding-Sync Also known as Sync v3 - https://github.com/matrix-org/sliding-sync label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Sliding-Sync Also known as Sync v3 - https://github.com/matrix-org/sliding-sync O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadLittleMods @duxovni @kegsay