Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document what a code review actually looks like #22250

Open
turt2live opened this issue May 17, 2022 · 0 comments
Open

Document what a code review actually looks like #22250

turt2live opened this issue May 17, 2022 · 0 comments
Labels
A-Documentation T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

We don't have docs for how a code review is done, which makes onboarding a bit difficult. How much do we care about code style? security? fixing the CI checks on behalf of the author? when do we reject? etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Documentation T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Johennes @turt2live