Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Can't load this message (m.room.message)" on reply in thread #22141

Closed
dinosmm opened this issue May 11, 2022 · 17 comments · Fixed by matrix-org/matrix-react-sdk#9356
Closed
Assignees
Labels
A-Threads A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Blocked X-Cannot-Reproduce Z-Rageshake Has attached rageshake (not for log submission process) Z-Soft-Crash React soft crash caught by an error boundary

Comments

@dinosmm
Copy link

dinosmm commented May 11, 2022

Steps to reproduce

I replied to a message in the main chat room, and chose to reply in thread, from Element Android.

In Element Web and Element Desktop, in place of my reply I see this:

Can't load this message (m.room.message)

'View source' shows the message text correctly.

Outcome

What did you expect?

I expected to see my threaded reply correctly in the web and desktop clients.

What happened instead?

I see the error message:
Can't load this message (m.room.message)

Underlying JavaScript error:

2022-05-13T10:31:28.021Z E Cannot read properties of null (reading 'getThreads')
TypeError: Cannot read properties of null (reading 'getThreads')
    at new F (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:636300)
    at k.getThreadsRoomState (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:637831)
    at Xe.setupNotificationListener (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~element-web-app.js:2:1047649)
    at Xe.componentDidMount (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~element-web-app.js:2:1052579)
    at hs (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3063847)
    at Cl (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3080905)
    at t.unstable_runWithPriority (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3106190)
    at zi (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3022782)
    at Fl (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3077450)
    at hl (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3073561)

Operating system

Windows 10

Application version

1.10.12

How did you install the app?

From the official website

Homeserver

Synapse 1.58.0

Will you send logs?

Yes

@SimonBrandner SimonBrandner added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline Z-Rageshake Has attached rageshake (not for log submission process) Z-Soft-Crash React soft crash caught by an error boundary A-Threads labels May 11, 2022
@markiceman
Copy link

I have the same problem. It is last message in thread.

It is really big problem. Threads in 1.10.12 are unusable.

@MadLittleMods
Copy link
Contributor

MadLittleMods commented May 14, 2022

Looking at rageshake logs reproducing this, the relevant error is:

2022-05-13T10:31:28.021Z E Cannot read properties of null (reading 'getThreads')
TypeError: Cannot read properties of null (reading 'getThreads')
    at new F (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:636300)
    at k.getThreadsRoomState (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:637831)
    at Xe.setupNotificationListener (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~element-web-app.js:2:1047649)
    at Xe.componentDidMount (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~element-web-app.js:2:1052579)
    at hs (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3063847)
    at Cl (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3080905)
    at t.unstable_runWithPriority (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3106190)
    at zi (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3022782)
    at Fl (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3077450)
    at hl (vector://vector/webapp/bundles/0dfc1e1dd51d68d7008e/vendors~init.js:2:3073561)

My issue is separate #22195 but has the same symptoms showing the tile error boundary.

@robintown robintown added the O-Occasional Affects or can be seen by some users regularly or most users rarely label May 16, 2022
@turt2live
Copy link
Member

stacktrace converted (loosely):

new ThreadsRoomNotificationState()
RoomNotificationStateStore#getThreadsRoomState // from the set call
EventTile#setupNotificationListener

this implies that thread.room is null, which is scary.

@turt2live
Copy link
Member

I'm unable to find a way to reproduce this, and can't seem to trick it into happening on my local machine. If people see this, please submit logs with a link to the message so we can attempt investigation that way.

It's quite clear from the log traffic that it's happening often, so upgrading occurrence rating.

@turt2live turt2live added X-Cannot-Reproduce O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed X-Needs-Investigation O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 16, 2022
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 17, 2022
This isn't called by an event handler directly, so shouldn't need to be bound. Equally, this shouldn't cause any problems.

This is a long-shot attempt at completing element-hq/element-web#22141
turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue May 17, 2022
@turt2live
Copy link
Member

Noting the "should never happen" cases, matrix-org/matrix-js-sdk#2375 attempts to add a more obvious error to locate what is going wrong and matrix-org/matrix-react-sdk#8618 is an extremely long shot at fixing this.

@markiceman
Copy link

What changed from 1.10.11 to 1.10.12? Version 1.10.11 don't have this problem.

@turt2live
Copy link
Member

Far too many changes to consider, unfortunately. There's a dozen things which were fixed or changed about Threads alone.

turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue May 17, 2022
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 17, 2022
This isn't called by an event handler directly, so shouldn't need to be bound. Equally, this shouldn't cause any problems.

This is a long-shot attempt at completing element-hq/element-web#22141
@markiceman
Copy link

markiceman commented May 17, 2022

Try "Clear cache and reload".

obrazek

@t3chguy
Copy link
Member

t3chguy commented May 17, 2022

What changed from 1.10.11 to 1.10.12? Version 1.10.11 don't have this problem.

A huge refactoring of how threads got created from being async to sync

@novocaine novocaine added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels May 19, 2022
@markiceman
Copy link

@t3chguy , @turt2live : Still cannot reproduce?

@turt2live
Copy link
Member

for now, yes. We're collecting more information until we have a cause determined.

Please continue to submit logs when the bug happens.

@JokerGermany
Copy link

grafik
On all rooms (element-Android, element-web and so on, will send logs)

@JokerGermany

This comment was marked as duplicate.

@JokerGermany
Copy link

Clearing Cache fixed it

@turt2live
Copy link
Member

@JokerGermany looks like your issue was something else, awkwardly. Fix/mitigation is up at matrix-org/matrix-react-sdk#8845

@germain-gg
Copy link
Contributor

This will be fixed once we land element-hq/element-meta#196 and #22981

@justjanne justjanne self-assigned this Oct 11, 2022
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Nov 12, 2022
* Loading threads with server-side assistance ([\matrix-org#9356](matrix-org#9356)). Fixes element-hq/element-web#21807, element-hq/element-web#21799, element-hq/element-web#21911, element-hq/element-web#22141, element-hq/element-web#22157, element-hq/element-web#22641, element-hq/element-web#22501 element-hq/element-web#22438 and element-hq/element-web#21678. Contributed by @justjanne.
* Make thread replies trigger a room list re-ordering ([\matrix-org#9510](matrix-org#9510)). Fixes element-hq/element-web#21700.
* Device manager - add extra details to device security and renaming ([\matrix-org#9501](matrix-org#9501)). Contributed by @kerryarchibald.
* Add plain text mode to the wysiwyg composer ([\matrix-org#9503](matrix-org#9503)). Contributed by @florianduros.
* Sliding Sync: improve sort order, show subspace rooms, better tombstoned room handling ([\matrix-org#9484](matrix-org#9484)).
* Device manager - add learn more popups to filtered sessions section ([\matrix-org#9497](matrix-org#9497)). Contributed by @kerryarchibald.
* Show thread notification if thread timeline is closed ([\matrix-org#9495](matrix-org#9495)). Fixes element-hq/element-web#23589.
* Add message editing to wysiwyg composer ([\matrix-org#9488](matrix-org#9488)). Contributed by @florianduros.
* Device manager - confirm sign out of other sessions ([\matrix-org#9487](matrix-org#9487)). Contributed by @kerryarchibald.
* Automatically request logs from other users in a call when submitting logs ([\matrix-org#9492](matrix-org#9492)).
* Add thread notification with server assistance (MSC3773) ([\matrix-org#9400](matrix-org#9400)). Fixes element-hq/element-web#21114, element-hq/element-web#21413, element-hq/element-web#21416, element-hq/element-web#21433, element-hq/element-web#21481, element-hq/element-web#21798, element-hq/element-web#21823 element-hq/element-web#23192 and element-hq/element-web#21765.
* Support for login + E2EE set up with QR ([\matrix-org#9403](matrix-org#9403)). Contributed by @hughns.
* Allow pressing Enter to send messages in new composer ([\matrix-org#9451](matrix-org#9451)). Contributed by @andybalaam.
* Fix regressions around media uploads failing and causing soft crashes ([\matrix-org#9549](matrix-org#9549)). Fixes matrix-org/element-web-rageshakes#16831, matrix-org/element-web-rageshakes#16824 matrix-org/element-web-rageshakes#16810 and element-hq/element-web#23641.
* Fix /myroomavatar slash command ([\matrix-org#9536](matrix-org#9536)). Fixes matrix-org/synapse#14321.
* Fix NotificationBadge unsent color ([\matrix-org#9522](matrix-org#9522)). Fixes element-hq/element-web#23646.
* Fix room list sorted by recent on app startup ([\matrix-org#9515](matrix-org#9515)). Fixes element-hq/element-web#23635.
* Reset custom power selector when blurred on empty ([\matrix-org#9508](matrix-org#9508)). Fixes element-hq/element-web#23481.
* Reinstate timeline/redaction callbacks when updating notification state ([\matrix-org#9494](matrix-org#9494)). Fixes element-hq/element-web#23554.
* Only render NotificationBadge when needed ([\matrix-org#9493](matrix-org#9493)). Fixes element-hq/element-web#23584.
* Fix embedded Element Call screen sharing ([\matrix-org#9485](matrix-org#9485)). Fixes element-hq/element-web#23571.
* Send Content-Type: application/json header for integration manager /register API ([\matrix-org#9490](matrix-org#9490)). Fixes element-hq/element-web#23580.
* Fix joining calls without audio or video inputs ([\matrix-org#9486](matrix-org#9486)). Fixes element-hq/element-web#23511.
* Ensure spaces in the spotlight dialog have rounded square avatars ([\matrix-org#9480](matrix-org#9480)). Fixes element-hq/element-web#23515.
* Only show mini avatar uploader in room intro when no avatar yet exists ([\matrix-org#9479](matrix-org#9479)). Fixes element-hq/element-web#23552.
* Fix threads fallback incorrectly targets root event ([\matrix-org#9229](matrix-org#9229)). Fixes element-hq/element-web#23147.
* Align video call icon with banner text ([\matrix-org#9460](matrix-org#9460)).
* Set relations helper when creating event tile context menu ([\matrix-org#9253](matrix-org#9253)). Fixes element-hq/element-web#22018.
* Device manager - put client/browser device metadata in correct section ([\matrix-org#9447](matrix-org#9447)). Contributed by @kerryarchibald.
* Update the room unread notification counter when the server changes the value without any related read receipt ([\matrix-org#9438](matrix-org#9438)).
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Nov 12, 2022
* Switch to notarytool ([\element-hq#440](element-hq#440)).
* Loading threads with server-side assistance ([\#9356](matrix-org/matrix-react-sdk#9356)). Fixes element-hq/element-web#21807, element-hq/element-web#21799, element-hq/element-web#21911, element-hq/element-web#22141, element-hq/element-web#22157, element-hq/element-web#22641, element-hq/element-web#22501 element-hq/element-web#22438 and element-hq/element-web#21678. Contributed by @justjanne.
* Make thread replies trigger a room list re-ordering ([\#9510](matrix-org/matrix-react-sdk#9510)). Fixes element-hq/element-web#21700.
* Device manager - add extra details to device security and renaming ([\#9501](matrix-org/matrix-react-sdk#9501)). Contributed by @kerryarchibald.
* Add plain text mode to the wysiwyg composer ([\#9503](matrix-org/matrix-react-sdk#9503)). Contributed by @florianduros.
* Sliding Sync: improve sort order, show subspace rooms, better tombstoned room handling ([\#9484](matrix-org/matrix-react-sdk#9484)).
* Device manager - add learn more popups to filtered sessions section ([\#9497](matrix-org/matrix-react-sdk#9497)). Contributed by @kerryarchibald.
* Show thread notification if thread timeline is closed ([\#9495](matrix-org/matrix-react-sdk#9495)). Fixes element-hq/element-web#23589.
* Add message editing to wysiwyg composer ([\#9488](matrix-org/matrix-react-sdk#9488)). Contributed by @florianduros.
* Device manager - confirm sign out of other sessions ([\#9487](matrix-org/matrix-react-sdk#9487)). Contributed by @kerryarchibald.
* Automatically request logs from other users in a call when submitting logs ([\#9492](matrix-org/matrix-react-sdk#9492)).
* Add thread notification with server assistance (MSC3773) ([\#9400](matrix-org/matrix-react-sdk#9400)). Fixes element-hq/element-web#21114, element-hq/element-web#21413, element-hq/element-web#21416, element-hq/element-web#21433, element-hq/element-web#21481, element-hq/element-web#21798, element-hq/element-web#21823 element-hq/element-web#23192 and element-hq/element-web#21765.
* Support for login + E2EE set up with QR ([\#9403](matrix-org/matrix-react-sdk#9403)). Contributed by @hughns.
* Allow pressing Enter to send messages in new composer ([\#9451](matrix-org/matrix-react-sdk#9451)). Contributed by @andybalaam.
* Fix regressions around media uploads failing and causing soft crashes ([\#9549](matrix-org/matrix-react-sdk#9549)). Fixes matrix-org/element-web-rageshakes#16831, matrix-org/element-web-rageshakes#16824 matrix-org/element-web-rageshakes#16810 and element-hq/element-web#23641.
* Fix /myroomavatar slash command ([\#9536](matrix-org/matrix-react-sdk#9536)). Fixes matrix-org/synapse#14321.
* Fix i18n interpolation ([\element-hq#432](element-hq#432)). Fixes element-hq/element-web#23568.
* Fix config.json failing to load for Jitsi wrapper in non-root deployment ([\#23577](element-hq/element-web#23577)).
* Fix NotificationBadge unsent color ([\#9522](matrix-org/matrix-react-sdk#9522)). Fixes element-hq/element-web#23646.
* Fix room list sorted by recent on app startup ([\#9515](matrix-org/matrix-react-sdk#9515)). Fixes element-hq/element-web#23635.
* Reset custom power selector when blurred on empty ([\#9508](matrix-org/matrix-react-sdk#9508)). Fixes element-hq/element-web#23481.
* Reinstate timeline/redaction callbacks when updating notification state ([\#9494](matrix-org/matrix-react-sdk#9494)). Fixes element-hq/element-web#23554.
* Only render NotificationBadge when needed ([\#9493](matrix-org/matrix-react-sdk#9493)). Fixes element-hq/element-web#23584.
* Fix embedded Element Call screen sharing ([\#9485](matrix-org/matrix-react-sdk#9485)). Fixes element-hq/element-web#23571.
* Send Content-Type: application/json header for integration manager /register API ([\#9490](matrix-org/matrix-react-sdk#9490)). Fixes element-hq/element-web#23580.
* Fix joining calls without audio or video inputs ([\#9486](matrix-org/matrix-react-sdk#9486)). Fixes element-hq/element-web#23511.
* Ensure spaces in the spotlight dialog have rounded square avatars ([\#9480](matrix-org/matrix-react-sdk#9480)). Fixes element-hq/element-web#23515.
* Only show mini avatar uploader in room intro when no avatar yet exists ([\#9479](matrix-org/matrix-react-sdk#9479)). Fixes element-hq/element-web#23552.
* Fix threads fallback incorrectly targets root event ([\#9229](matrix-org/matrix-react-sdk#9229)). Fixes element-hq/element-web#23147.
* Align video call icon with banner text ([\#9460](matrix-org/matrix-react-sdk#9460)).
* Set relations helper when creating event tile context menu ([\#9253](matrix-org/matrix-react-sdk#9253)). Fixes element-hq/element-web#22018.
* Device manager - put client/browser device metadata in correct section ([\#9447](matrix-org/matrix-react-sdk#9447)). Contributed by @kerryarchibald.
* Update the room unread notification counter when the server changes the value without any related read receipt ([\#9438](matrix-org/matrix-react-sdk#9438)).
su-ex added a commit to SchildiChat/element-web that referenced this issue Nov 12, 2022
* Loading threads with server-side assistance ([\element-hq#9356](matrix-org/matrix-react-sdk#9356)). Fixes element-hq#21807, element-hq#21799, element-hq#21911, element-hq#22141, element-hq#22157, element-hq#22641, element-hq#22501 element-hq#22438 and element-hq#21678. Contributed by @justjanne.
* Make thread replies trigger a room list re-ordering ([\element-hq#9510](matrix-org/matrix-react-sdk#9510)). Fixes element-hq#21700.
* Device manager - add extra details to device security and renaming ([\element-hq#9501](matrix-org/matrix-react-sdk#9501)). Contributed by @kerryarchibald.
* Add plain text mode to the wysiwyg composer ([\element-hq#9503](matrix-org/matrix-react-sdk#9503)). Contributed by @florianduros.
* Sliding Sync: improve sort order, show subspace rooms, better tombstoned room handling ([\element-hq#9484](matrix-org/matrix-react-sdk#9484)).
* Device manager - add learn more popups to filtered sessions section ([\element-hq#9497](matrix-org/matrix-react-sdk#9497)). Contributed by @kerryarchibald.
* Show thread notification if thread timeline is closed ([\element-hq#9495](matrix-org/matrix-react-sdk#9495)). Fixes element-hq#23589.
* Add message editing to wysiwyg composer ([\element-hq#9488](matrix-org/matrix-react-sdk#9488)). Contributed by @florianduros.
* Device manager - confirm sign out of other sessions ([\element-hq#9487](matrix-org/matrix-react-sdk#9487)). Contributed by @kerryarchibald.
* Automatically request logs from other users in a call when submitting logs ([\element-hq#9492](matrix-org/matrix-react-sdk#9492)).
* Add thread notification with server assistance (MSC3773) ([\element-hq#9400](matrix-org/matrix-react-sdk#9400)). Fixes element-hq#21114, element-hq#21413, element-hq#21416, element-hq#21433, element-hq#21481, element-hq#21798, element-hq#21823 element-hq#23192 and element-hq#21765.
* Support for login + E2EE set up with QR ([\element-hq#9403](matrix-org/matrix-react-sdk#9403)). Contributed by @hughns.
* Allow pressing Enter to send messages in new composer ([\element-hq#9451](matrix-org/matrix-react-sdk#9451)). Contributed by @andybalaam.
* Fix regressions around media uploads failing and causing soft crashes ([\element-hq#9549](matrix-org/matrix-react-sdk#9549)). Fixes matrix-org/element-web-rageshakes#16831, matrix-org/element-web-rageshakes#16824 matrix-org/element-web-rageshakes#16810 and element-hq#23641.
* Fix /myroomavatar slash command ([\element-hq#9536](matrix-org/matrix-react-sdk#9536)). Fixes matrix-org/synapse#14321.
* Fix config.json failing to load for Jitsi wrapper in non-root deployment ([\element-hq#23577](element-hq#23577)).
* Fix NotificationBadge unsent color ([\element-hq#9522](matrix-org/matrix-react-sdk#9522)). Fixes element-hq#23646.
* Fix room list sorted by recent on app startup ([\element-hq#9515](matrix-org/matrix-react-sdk#9515)). Fixes element-hq#23635.
* Reset custom power selector when blurred on empty ([\element-hq#9508](matrix-org/matrix-react-sdk#9508)). Fixes element-hq#23481.
* Reinstate timeline/redaction callbacks when updating notification state ([\element-hq#9494](matrix-org/matrix-react-sdk#9494)). Fixes element-hq#23554.
* Only render NotificationBadge when needed ([\element-hq#9493](matrix-org/matrix-react-sdk#9493)). Fixes element-hq#23584.
* Fix embedded Element Call screen sharing ([\element-hq#9485](matrix-org/matrix-react-sdk#9485)). Fixes element-hq#23571.
* Send Content-Type: application/json header for integration manager /register API ([\element-hq#9490](matrix-org/matrix-react-sdk#9490)). Fixes element-hq#23580.
* Fix joining calls without audio or video inputs ([\element-hq#9486](matrix-org/matrix-react-sdk#9486)). Fixes element-hq#23511.
* Ensure spaces in the spotlight dialog have rounded square avatars ([\element-hq#9480](matrix-org/matrix-react-sdk#9480)). Fixes element-hq#23515.
* Only show mini avatar uploader in room intro when no avatar yet exists ([\element-hq#9479](matrix-org/matrix-react-sdk#9479)). Fixes element-hq#23552.
* Fix threads fallback incorrectly targets root event ([\element-hq#9229](matrix-org/matrix-react-sdk#9229)). Fixes element-hq#23147.
* Align video call icon with banner text ([\element-hq#9460](matrix-org/matrix-react-sdk#9460)).
* Set relations helper when creating event tile context menu ([\element-hq#9253](matrix-org/matrix-react-sdk#9253)). Fixes element-hq#22018.
* Device manager - put client/browser device metadata in correct section ([\element-hq#9447](matrix-org/matrix-react-sdk#9447)). Contributed by @kerryarchibald.
* Update the room unread notification counter when the server changes the value without any related read receipt ([\element-hq#9438](matrix-org/matrix-react-sdk#9438)).
@christro
Copy link

I have the same problems with https://app.element.io in Mac OS: Can't load this message (m.room.message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Blocked X-Cannot-Reproduce Z-Rageshake Has attached rageshake (not for log submission process) Z-Soft-Crash React soft crash caught by an error boundary
Projects
None yet
Development

Successfully merging a pull request may close this issue.