Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear you can start a DM conversation before the invite was accepted #21353

Closed
raboof opened this issue Mar 8, 2022 · 6 comments
Closed
Assignees
Labels
A-DMs O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Design

Comments

@raboof
Copy link

raboof commented Mar 8, 2022

Your use case

What would you like to do?

I would like to add a note to the DM caption explaining that you can start talking even before the other user has accepted the invite.

Why would you like to do it?

Currently, when you start a DM, you can see that the other user has been invited to the DM, but it is unclear whether after accepting the invite, they will see the messages you sent before they accepted the invite.

(this problem is amplified by the fact that sometimes, in case of problems with encryption keys, the other user actually cannot read the messages from before the invite. That is not the typical scenario, so I don't think we should mention that, but it does make it extra useful to make it clear that in the regular scenario you can start sending messages immediately)

How would you like to achieve it?

With matrix-org/matrix-react-sdk#7998 😄

Have you considered any alternatives?

We might give the whole DM flow a more holistic overhaul (e.g. some of the ideas in #15733).

I think adding a note is a useful simple improvement we can do now. It can always be removed again when/if the flow is improved such that it is no longer needed.

Additional context

No response

@daniellekirkwood
Copy link
Contributor

Thanks so much for creating this issue!

@guillaumevillemont & @gaelledel This might be of particular interest to you, as a stop gap and opportunity to test as we discuss further DM improvements. WDYT

@germain-gg germain-gg added O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Design labels Mar 9, 2022
@giomfo
Copy link
Member

giomfo commented Mar 9, 2022

Thanks so much for creating this issue!

@guillaumevillemont & @gaelledel This might be of particular interest to you, as a stop gap and opportunity to test as we discuss further DM improvements. WDYT

I confirm (@daniellekirkwood, FYI my github username is @giomfo)

@daniellekirkwood
Copy link
Contributor

I confirm (@daniellekirkwood, FYI my github username is @giomfo)

Oops! Thank you :)

@giomfo
Copy link
Member

giomfo commented Mar 18, 2022

@raboof FYI I just described our plan here about creating the DM only on first message

Do you agree to close your request according to this plan?

@raboof
Copy link
Author

raboof commented Mar 18, 2022

@raboof FYI I just described our plan here about creating the DM only on first message

Looks like a great alternative!

Do you agree to close your request according to this plan?

That depends on the timeline on which you plan to implement #14736 ;) - if that's still a while in the future we can leave this and matrix-org/matrix-react-sdk#7998 open on the chance that it might be ready to go in sooner. If you're actively working on #14736 and expect to ship it soon then I agree we can close this and matrix-org/matrix-react-sdk#7998

@turt2live
Copy link
Member

I believe this is an effective duplicate of #14736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-DMs O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants