Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design for the new search experience to include public rooms and people in results #21352

Closed
2 tasks done
Tracked by #20616
kittykat opened this issue Mar 8, 2022 · 5 comments
Closed
2 tasks done
Tracked by #20616
Assignees
Labels
A-New-Search-Experience The new search dialog available in Labs T-Enhancement Z-IA Issues relating to information architecture Z-Labs

Comments

@kittykat
Copy link
Contributor

kittykat commented Mar 8, 2022

To provide a seamless experience, "Explore Rooms"/"Public Rooms" and "Direct Messages"/"People" dialogs should be part of the new search experience using filtering.

Tasks

@kittykat kittykat added A-New-Search-Experience The new search dialog available in Labs T-Enhancement Z-IA Issues relating to information architecture Z-TeamDelight labels Mar 8, 2022
@github-actions github-actions bot added the Z-Labs label Mar 8, 2022
@niquewoodhouse
Copy link

Flow examples for discussion:

ele-web-search-add-people-and-public-rooms.mov

I think this could lead to some UX complications for users who don't understand the history of public room directory and spaces. So eventually, there might be a need to include a broader filter that lets people select spaces to search, but I obviously don't understand complexities in this area and I'm assuming a bit myself.

Search_amends1 2@2x

@niquewoodhouse
Copy link

@kittykat @t3chguy Hi, would you mind feeding back on this design proposal please. I've tried to make them reflect the existing public rooms and people UX as much as possible, rather than rethink anything.

I think longer term making the public rooms server picker act more like a bigger filter might help users find the right rooms, but I think that's likely out of scope for now and needs more insights.

@t3chguy
Copy link
Member

t3chguy commented Mar 24, 2022

Hey @niquewoodhouse - thanks for taking time to do such a detailed design.

Search for section added to top of pre-input

Not sure how I feel about this, given that once you start filtering and you don't find what you're looking for you are met with similar buttons, and by selecting them your query is maintained. Happy to keep it but it means swapping to the last room you were in is no longer Cmd + K Enter


If you can't see who you're looking for, send them your invite link.

I think this should be a tile so that its do-able with the keyboard, not requiring mouse, right now it looks like a block of text with a link around a small part of it.

People flow

Right now it only seems to have the Suggestions category but our current implementation also shows you Recent conversations, is this intentionally removed?

Rest of it looks GREAT


Some results may be hidden for privacy

This isn't quite true, its more that some rooms just choose not to be published

If you can't find the room you're looking for, ask for an invite or create a new room.

I think this should be a tile so that its do-able with the keyboard, not requiring mouse, right now it looks like a block of text with a link around a small part of it. (same as People flow above)

Public room flow

Looks good, kinda worried about the dropdown but its certainly no worse than today!


Down arrow highlights option similarly to other things in search
If user Esc, hint disappears

I don't think we can express this is in a way which won't confuse screen reader users
I think relying on Search for section added to top of pre-input might be most sane, we could special-case that the Search for stays at the top if your input looks like People or Public rooms

@niquewoodhouse
Copy link

Thanks @t3chguy for the thorough look through. Based on your input I've made a new version here

  • amends the pre-input to not show buttons
  • changes actions in people and room lists (create new room + copy link) to be tiles
  • removes privacy reference from end of room list results
  • remove ideas around using input to show a dropdown
  • adds in the recent conversations section for people (but hides it if there's no match in the section)

@t3chguy
Copy link
Member

t3chguy commented Mar 24, 2022

This is great, one other thing, these don't look like tiles (because they feature a button unlike all other tiles)

image

Presumably arrow keys will still move between them, could we get a hover/active state design just to see what one of these huge "tiles" looks like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-New-Search-Experience The new search dialog available in Labs T-Enhancement Z-IA Issues relating to information architecture Z-Labs
Projects
None yet
Development

No branches or pull requests

3 participants