Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't forward image from a thread #21015

Closed
HarHarLinks opened this issue Feb 9, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7929
Closed

Can't forward image from a thread #21015

HarHarLinks opened this issue Feb 9, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7929
Assignees
Labels
A-Message-Forwarding A-Threads S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement Z-Labs

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

  1. go to https://matrix.to/#/!AZozoWghOYSIAfaZjJ:matrix.org/$jf9BUsdwpskZIMklDOMzqE6P1CdzXfZWoig3-nuht38?via=matrix.org&via=privacytools.io&via=tchncs.de
  2. the source is structured like this, not sure if that's a proper thread event or not, so pasting here:
{
  "content": {
    "body": "image.png",
    "info": {
      "h": 707,
      "mimetype": "image/png",
      "size": 518253,
      "thumbnail_info": {
        "h": 600,
        "mimetype": "image/png",
        "size": 458227,
        "w": 466
      },
      "thumbnail_url": "mxc://xxx",
      "w": 550,
      "xyz.amorgan.blurhash": "T4RfIGO@=s#m*J00EfB:%2QmH?w^"
    },
    "m.relates_to": {
      "event_id": "$yyy",
      "m.in_reply_to": {
        "event_id": "$zzz"
      },
      "rel_type": "io.element.thread"
    },
    "msgtype": "m.image",
    "url": "mxc://XXX"
  },
  "origin_server_ts": 1644415812501,
  "sender": "@aaa",
  "type": "m.room.message",
  "unsigned": {},
  "event_id": "$bbb",
  "room_id": "!AZozoWghOYSIAfaZjJ:matrix.org"
}
  1. click to forward the image

Outcome

What did you expect?

forward the simple image

What happened instead?

  1. it's preview is formatted like a reply (not even like a thread), when it should forward a simple message
  2. it fails to send
    image

Operating system

arch

Application version

Element Nightly version: 2022020901 Olm version: 3.2.8

How did you install the app?

aur

Homeserver

1.51

Will you send logs?

No

@SimonBrandner SimonBrandner added A-Message-Forwarding A-Threads S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 9, 2022
@github-actions github-actions bot added the Z-Labs label Feb 9, 2022
@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Feb 9, 2022

Closely related, forwarding an image that is a reply on stable 1.10.1 will include the reference (m.relates_to dict) from that reply, which just doesn't work:

Unable to load event that was replied to, it either does not exist or you do not have permission to view it.

The preview shows that it will try to include the reference of the reply to, but not that it will fail, nor does it give the option to strip it or convert it to a reply fallback(?) which of course is nonsensical with replied images.

Of course this whole issue is intertwined with the deprecation/revamp of reply fallbacks in spec.

I propose to add above mentioned 3 choices to the forwarding dialogue (only shown when the context permits = there is m.relates_to data).

@daniellekirkwood
Copy link
Contributor

I can't replicate the "reply" with forwarding but I do encounter an error when trying to forward a message in a thread to another room.

I think this falls into the fast follow epic along with things like "voice messages" so I'll remove the Needs-Product label and update the issue to reflect that.

If you have any other questions, tag me :)

@daniellekirkwood daniellekirkwood removed the X-Needs-Product More input needed from the Product team label Mar 9, 2022
kegsay added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 14, 2022
* Release threads as a beta feature ([\#8081](#8081)). Fixes element-hq/element-web#21351.
* More video rooms design updates ([\#8222](#8222)).
* Update video rooms to new design specs ([\#8207](#8207)). Fixes element-hq/element-web#21515, element-hq/element-web#21516 element-hq/element-web#21519 and element-hq/element-web#21526.
* Live Location Sharing - left panel warning with error ([\#8201](#8201)).
* Live location sharing - Stop publishing location to beacons with consecutive errors ([\#8194](#8194)).
* Live location sharing: allow retry when stop sharing fails ([\#8193](#8193)).
* Allow voice messages to be scrubbed in the timeline ([\#8079](#8079)). Fixes element-hq/element-web#18713.
* Live location sharing - stop sharing to beacons in rooms you left ([\#8187](#8187)).
* Allow sending and thumbnailing AVIF images ([\#8172](#8172)).
* Live location sharing - handle geolocation errors ([\#8179](#8179)).
* Show voice room participants when not connected ([\#8136](#8136)). Fixes element-hq/element-web#21513.
* Add margins between labs sections ([\#8169](#8169)).
* Live location sharing - send geolocation beacon events - happy path ([\#8127](#8127)).
* Add support for Animated (A)PNG ([\#8158](#8158)). Fixes element-hq/element-web#12967.
* Don't form continuations from thread roots ([\#8166](#8166)). Fixes element-hq/element-web#20908.
* Improve handling of animated GIF and WEBP images ([\#8153](#8153)). Fixes element-hq/element-web#16193 and element-hq/element-web#6684.
* Wire up file preview for video files ([\#8140](#8140)). Fixes element-hq/element-web#21539.
* When showing thread, always auto-focus its composer ([\#8115](#8115)). Fixes element-hq/element-web#21438.
* Live location sharing - refresh beacon expiry in room ([\#8116](#8116)).
* Use styled mxids in member list v2 ([\#8110](#8110)). Fixes element-hq/element-web#14825. Contributed by @SimonBrandner.
* Delete groups (legacy communities system) ([\#8027](#8027)). Fixes element-hq/element-web#17532.
* Add a prototype of voice rooms in labs ([\#8084](#8084)). Fixes element-hq/element-web#3546.
* Fix editing `<ol>` tags with a non-1 start attribute ([\#8211](#8211)). Fixes element-hq/element-web#21625.
* Fix URL previews being enabled when room first created ([\#8227](#8227)). Fixes element-hq/element-web#21659.
* Don't use m.call for Jitsi video rooms ([\#8223](#8223)).
* Scale emoji with size of surrounding text ([\#8224](#8224)).
* Make "Jump to date" translatable ([\#8218](#8218)).
* Normalize call buttons ([\#8129](#8129)). Fixes element-hq/element-web#21493. Contributed by @luixxiul.
* Show room preview bar with maximised widgets ([\#8180](#8180)). Fixes element-hq/element-web#21542.
* Update more strings to not wrongly mention room when it is/could be a space ([\#7722](#7722)). Fixes element-hq/element-web#20243 and element-hq/element-web#20910.
* Fix issue with redacting via edit composer flow causing stuck editStates ([\#8184](#8184)).
* Fix some image/video scroll jumps ([\#8182](#8182)).
* Fix "react error on share dialog" ([\#8170](#8170)). Contributed by @yaya-usman.
* Fix disambiguated profile in threads in bubble layout ([\#8168](#8168)). Fixes element-hq/element-web#21570. Contributed by @SimonBrandner.
* Responsive BetaCard on Labs ([\#8154](#8154)). Fixes element-hq/element-web#21554. Contributed by @luixxiul.
* Display button as inline in room directory dialog ([\#8164](#8164)). Fixes element-hq/element-web#21567. Contributed by @luixxiul.
* Null guard TimelinePanel unmount edge ([\#8171](#8171)).
* Fix beta pill label breaking ([\#8162](#8162)). Fixes element-hq/element-web#21566. Contributed by @luixxiul.
* Strip relations when forwarding ([\#7929](#7929)). Fixes element-hq/element-web#19769, element-hq/element-web#18067 element-hq/element-web#21015 and element-hq/element-web#10924.
* Don't try (and fail) to show replies for redacted events ([\#8141](#8141)). Fixes element-hq/element-web#21435.
* Fix 3pid member info for space member list ([\#8128](#8128)). Fixes element-hq/element-web#21534.
* Set max-width to user context menu ([\#8089](#8089)). Fixes element-hq/element-web#21486. Contributed by @luixxiul.
* Fix issue with falsey hrefs being sent in events ([\#8113](#8113)). Fixes element-hq/element-web#21417.
* Make video sizing consistent with images ([\#8102](#8102)). Fixes element-hq/element-web#20072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Forwarding A-Threads S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants