-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIP window closes when you switch to another room #20913
Comments
I could circumvent the bug by unpinning the widget, opening it in the sidebar and then enable PIP. |
Ah right, if @aWeinzierl means browser-specific features like that (as opposed to similar widget capabilities to persist the widget across rooms), then it's "expected" at the moment. I do see though that some browsers will actually emit events when these "browser PIP" features are used... but it's not yet available in all browsers Element Web supports. |
That event is also fired on the |
Thanks for the additional screenshots. Those features are all implemented by the browser's own functionality for HTML video elements. It is not something that the widget or Element have built or are aware of. If you go to any HTML video, such as the one on the page at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video, you should see the same menus you are describing on that video as well.
The widget author can build the widget to request the capability "always on screen". This will trigger a permission prompt when the widget loads for you to agree to that. The widget can then notify Element of times it wants to stay on screen. There is currently no user-level feature to force a widget to stay on screen. Perhaps there should be, but that seems like a separate enhancement issue. |
|
Given that this widget seems to be operating as expected within the constraints of widgets, and there's also a separate issue for a user-level toggle, I think it's best to close this issue. |
It'd be good if the FOSDEM/conf widget listened for the video element's PIP event and translated it into a Widget PIP caps event tbh |
Steps to reproduce
(unfortunately doesn't reproduce reliably, however when the underlying problem seems active, it works all the time )
A new day, opening chat.fosdem.org: no problems;
After closing the tab with an active chat.fosdem.org session (verified) after a few minutes and reopening it:
Outcome
What did you expect?
PIP window stays visible
What happened instead?
PIP window vanishes
Operating system
Windows 10 Pro 19044.1469
Browser information
Edge Version 97.0.1072.76 (Official build) (64-bit)
URL for webapp
https://chat.fosdem.org/
Application version
FOSDEM 2022 version: 1.10.1 Olm version: 3.2.8
Homeserver
matrix.org
Will you send logs?
Yes -> https://github.com/matrix-org/element-web-rageshakes/issues/10382
The text was updated successfully, but these errors were encountered: