Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyboard shortcut to toggle Show hidden events in timeline #20646

Closed
HarHarLinks opened this issue Jan 19, 2022 · 6 comments
Closed

add keyboard shortcut to toggle Show hidden events in timeline #20646

HarHarLinks opened this issue Jan 19, 2022 · 6 comments
Assignees
Labels
A-Developer-Experience A-Shortcuts Keyboard shortcuts A-Timeline A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement

Comments

@HarHarLinks
Copy link
Contributor

Your use case

What would you like to do?

toggle the labs setting Show hidden events in timeline by keyboard combination

Why would you like to do it?

Show hidden events in timeline is at the very bottom of a 3 deep menu (main menu, settings, labs, scroll to bottom). Switching back and forth is quite the hassle

How would you like to achieve it?

add a keyboard shortcut like Ctrl+Shift+H

Have you considered any alternatives?

add it to quick settings if developer mode is on or so

Additional context

No response

@SimonBrandner SimonBrandner added A-Developer-Experience A-Shortcuts Keyboard shortcuts A-Timeline A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 19, 2022
@UwUnyaa
Copy link

UwUnyaa commented Jan 19, 2022

Do you need to enable some sort of developer mode in order to be able to view the labs tab in settings? I cannot find it, even in element running in dev mode.

@UwUnyaa
Copy link

UwUnyaa commented Jan 19, 2022

I just found that it's an option in settings.json. I assume this means this shortcut should be only present if that option is enabled.

@HarHarLinks
Copy link
Contributor Author

I cannot find it, even in element running in dev mode.

perhaps it should get moved out of labs into dev mode anyway? it's not an experimental element feature, but a dev feature(?)

@UwUnyaa
Copy link

UwUnyaa commented Jan 19, 2022

It's only available if you enable labs. Because of that, the amount of changes is slightly larger. I almost have an initial patch ready, I just ran into some tooling issues, preventing me from creating clean diffs.

@dbkr
Copy link
Member

dbkr commented Jan 20, 2022

Yeah, develop.element.io and the nightly desktop build have that option on and so have labs available. And yep, it's one of the advanced / developer settings that's got mixed up under labs, so shouldn't really be there. Thanks for looking at this!

@t3chguy
Copy link
Member

t3chguy commented Jan 26, 2022

Merged

@t3chguy t3chguy closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience A-Shortcuts Keyboard shortcuts A-Timeline A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants