Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp on videos with message bubbles obstructs controls #20420

Open
t3chguy opened this issue Jan 6, 2022 · 3 comments
Open

Timestamp on videos with message bubbles obstructs controls #20420

t3chguy opened this issue Jan 6, 2022 · 3 comments

Comments

@t3chguy
Copy link
Member

t3chguy commented Jan 6, 2022

image

We might need to have alternate placement for timestamps here, we have no way of knowing the position/dimensions of the video controls as they vary per browser/environment.

@github-actions github-actions bot added the Z-Labs label Jan 6, 2022
@germain-gg germain-gg added the T-Task Tasks for the team like planning label Jan 7, 2022
@amshakal
Copy link

Hi, I think it's okay for timestamp to not be visible once a video is playing. By the time when it's on the state below it's visible. I have also added a small gradient overlay at the bottom to make sure the time stamp is visible on images as well as videos.
Screenshot 2022-01-12 at 4 33 02 pm

Screenshot 2022-01-12 at 4 33 59 pm

Link to Figma: https://www.figma.com/file/zVtAKK0hzKu5JkpbzlE1pG/Message-Bubbles?node-id=1691%3A38484

@t3chguy
Copy link
Member Author

t3chguy commented Jan 12, 2022

Hi, I think it's okay for timestamp to not be visible once a video is playing.

This doesn't scale well, the pre-playback (poster) view is dependent on browser doesn't look very much like what the Figma assumes, it has the controls there already. Designing our own video playback components would be a lot of work to scope-creep into Bubbles work.

Chrome:
image
Firefox
image

We also allow the user to have their videos autoplay to match other platforms, so then they would never see the timestamp of the video anyway.

image

@daniellekirkwood
Copy link
Contributor

This is great feedback, and there's definitely improvements to be made but for our first release I'm choosing to descope this.

I will mark this as V2 and as an Enhancement, we can come back to it after launch

@daniellekirkwood daniellekirkwood added T-Enhancement and removed T-Task Tasks for the team like planning labels Jan 18, 2022
@t3chguy t3chguy added the A11y label Jan 18, 2022
@robintown robintown removed the Z-Labs label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants