Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering for my issues in threads is broken #19809

Closed
kittykat opened this issue Nov 18, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#7169
Closed

Filtering for my issues in threads is broken #19809

kittykat opened this issue Nov 18, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#7169
Assignees
Labels
A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Community-Testing

Comments

@kittykat
Copy link
Contributor

Steps to reproduce

  1. Go to Thread side panel (view all threads)
  2. Change filter top-right to view only your threads

Outcome

What did you expect?

To see all threads I'm participating in

What happened instead?

I can only see threads which I started

Operating system

No response

Browser information

Chromium 95.0.4638.69 (Official Build) Arch Linux (64-bit)

URL for webapp

develop.element.io

Application version

Element version: b2e8f21-react-256c468c15a3-js-af523522def0 Olm version: 3.2.3

Homeserver

No response

Will you send logs?

No

@kittykat kittykat added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Threads Z-Community-Testing labels Nov 18, 2021
@germain-gg
Copy link
Contributor

germain-gg commented Nov 19, 2021

Should a reaction be counted as a participation in a thread?

@clokep
Copy link

clokep commented Nov 19, 2021

See matrix-org/synapse#11399

@janogarcia
Copy link

@gsouquet As discussed in the duplicate issue (now closed), the following interactions should be considered high signal and thus be part of the matching criteria for the "My threads" filter:

  • Starting a thread
  • Replying to a thread

Ideally we'd also consider mentions, but as you already pointed out that's not going to work at all for encrypted rooms, so we have dropped that requirement.

As for reactions, we consider those low signal/engagement, so those should be excluded. A proper follow/unfollow mechanism, planned for a future release, would allow users to selectively follow threads even if they haven't actively participated in them.

/cc @daniellekirkwood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Community-Testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants