Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forwarding a message which was a reply to another room has poor UX #19769

Closed
DMRobertson opened this issue Nov 16, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7929
Closed

Forwarding a message which was a reply to another room has poor UX #19769

DMRobertson opened this issue Nov 16, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7929
Assignees
@t3chguy
Labels
A-Error-Message A-Message-Forwarding A-Replies reply O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team

Comments

@DMRobertson
Copy link

Your use case

In room A, someone posts a message. I write a reply to it.
We both realise that this should conversation should have taken place in room B.
I forward my reply to room B and delete my reply from room A.

What I see in room B:
Screenshot from 2021-11-16 14-41-36

The text of reply was reproduced correctly. The fact that it was a reply was also copied over. But we can't see what I replied to.

The error message

Unable to load event that was replied to, it either does not exist or you do not have permission to view it.

Is slightly misleading. The event in question exists, just not in this room.

Thoughts:

  • It would be great if the client could detect that this event was in another room and load it for me.
  • But then again, some users in room B might not be in room A, so maybe it's better to show "not everyone can see this".
  • Perhaps the client could warn that users won't be able to see what I was replying to when forwarding a reply?

Have you considered any alternatives?

No response

Additional context

No response
@Palid Palid added X-Needs-Design O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Product More input needed from the Product team labels Nov 17, 2021
@HarHarLinks
Copy link
Contributor

more ideas and options:

  • add a checkbox to forward UI to switch between forward only the reply or forward the original message + reply
  • include the original msg as a quote instead of linked reply: doesn't leak others metadata, like forwarding someone else's msg currently works.
    • maybe not possible with current spec, but show the rich reply to users who can access the original but regular quote otherwise. downside: people see different things.

@yannicka yannicka mentioned this issue Dec 11, 2021
Open
@t3chguy
Copy link
Member

t3chguy commented Mar 1, 2022

It would be great if the client could detect that this event was in another room and load it for me.

The spec doesn't allow for this, only the event_id is included, no room_id

@t3chguy t3chguy self-assigned this Mar 1, 2022
@t3chguy t3chguy mentioned this issue Mar 1, 2022
Merged
@MadLittleMods MadLittleMods mentioned this issue Mar 23, 2022
Open
kegsay added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 14, 2022
@kegsay
Merge tag 'v3.42.3' into kegan/sync-v3
4efc389 
* Release threads as a beta feature ([\#8081](#8081)). Fixes element-hq/element-web#21351.
* More video rooms design updates ([\#8222](#8222)).
* Update video rooms to new design specs ([\#8207](#8207)). Fixes element-hq/element-web#21515, element-hq/element-web#21516 element-hq/element-web#21519 and element-hq/element-web#21526.
* Live Location Sharing - left panel warning with error ([\#8201](#8201)).
* Live location sharing - Stop publishing location to beacons with consecutive errors ([\#8194](#8194)).
* Live location sharing: allow retry when stop sharing fails ([\#8193](#8193)).
* Allow voice messages to be scrubbed in the timeline ([\#8079](#8079)). Fixes element-hq/element-web#18713.
* Live location sharing - stop sharing to beacons in rooms you left ([\#8187](#8187)).
* Allow sending and thumbnailing AVIF images ([\#8172](#8172)).
* Live location sharing - handle geolocation errors ([\#8179](#8179)).
* Show voice room participants when not connected ([\#8136](#8136)). Fixes element-hq/element-web#21513.
* Add margins between labs sections ([\#8169](#8169)).
* Live location sharing - send geolocation beacon events - happy path ([\#8127](#8127)).
* Add support for Animated (A)PNG ([\#8158](#8158)). Fixes element-hq/element-web#12967.
* Don't form continuations from thread roots ([\#8166](#8166)). Fixes element-hq/element-web#20908.
* Improve handling of animated GIF and WEBP images ([\#8153](#8153)). Fixes element-hq/element-web#16193 and element-hq/element-web#6684.
* Wire up file preview for video files ([\#8140](#8140)). Fixes element-hq/element-web#21539.
* When showing thread, always auto-focus its composer ([\#8115](#8115)). Fixes element-hq/element-web#21438.
* Live location sharing - refresh beacon expiry in room ([\#8116](#8116)).
* Use styled mxids in member list v2 ([\#8110](#8110)). Fixes element-hq/element-web#14825. Contributed by @SimonBrandner.
* Delete groups (legacy communities system) ([\#8027](#8027)). Fixes element-hq/element-web#17532.
* Add a prototype of voice rooms in labs ([\#8084](#8084)). Fixes element-hq/element-web#3546.
* Fix editing `<ol>` tags with a non-1 start attribute ([\#8211](#8211)). Fixes element-hq/element-web#21625.
* Fix URL previews being enabled when room first created ([\#8227](#8227)). Fixes element-hq/element-web#21659.
* Don't use m.call for Jitsi video rooms ([\#8223](#8223)).
* Scale emoji with size of surrounding text ([\#8224](#8224)).
* Make "Jump to date" translatable ([\#8218](#8218)).
* Normalize call buttons ([\#8129](#8129)). Fixes element-hq/element-web#21493. Contributed by @luixxiul.
* Show room preview bar with maximised widgets ([\#8180](#8180)). Fixes element-hq/element-web#21542.
* Update more strings to not wrongly mention room when it is/could be a space ([\#7722](#7722)). Fixes element-hq/element-web#20243 and element-hq/element-web#20910.
* Fix issue with redacting via edit composer flow causing stuck editStates ([\#8184](#8184)).
* Fix some image/video scroll jumps ([\#8182](#8182)).
* Fix "react error on share dialog" ([\#8170](#8170)). Contributed by @yaya-usman.
* Fix disambiguated profile in threads in bubble layout ([\#8168](#8168)). Fixes element-hq/element-web#21570. Contributed by @SimonBrandner.
* Responsive BetaCard on Labs ([\#8154](#8154)). Fixes element-hq/element-web#21554. Contributed by @luixxiul.
* Display button as inline in room directory dialog ([\#8164](#8164)). Fixes element-hq/element-web#21567. Contributed by @luixxiul.
* Null guard TimelinePanel unmount edge ([\#8171](#8171)).
* Fix beta pill label breaking ([\#8162](#8162)). Fixes element-hq/element-web#21566. Contributed by @luixxiul.
* Strip relations when forwarding ([\#7929](#7929)). Fixes element-hq/element-web#19769, element-hq/element-web#18067 element-hq/element-web#21015 and element-hq/element-web#10924.
* Don't try (and fail) to show replies for redacted events ([\#8141](#8141)). Fixes element-hq/element-web#21435.
* Fix 3pid member info for space member list ([\#8128](#8128)). Fixes element-hq/element-web#21534.
* Set max-width to user context menu ([\#8089](#8089)). Fixes element-hq/element-web#21486. Contributed by @luixxiul.
* Fix issue with falsey hrefs being sent in events ([\#8113](#8113)). Fixes element-hq/element-web#21417.
* Make video sizing consistent with images ([\#8102](#8102)). Fixes element-hq/element-web#20072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Error-Message A-Message-Forwarding A-Replies reply O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strip relations when forwarding matrix-org/matrix-react-sdk
5 participants
@t3chguy @HarHarLinks @Palid @aaronraimist @DMRobertson