Room alias address isn't checked for validity before being shown as added

[kittykat]

Steps to reproduce

1. Go to room settings (in the left panel, ⋯ -> Settings)
2. Under Room Addresses -> Published Addresses, add and address that looks like "#someaddress"
3. Add
4. Get pop-up with "Error updating main address"
5. Close dialog
6. See bad alias shown in the list
7. Under "main address" dropdown, see the bad alias listed
8. Select the bad alias under "main address" to get another error dialog

Outcome

What did you expect?

Basic validation check when tabbing out of the field (like on login with password or email) and for the alias to not be shown if it fails to be added.

What happened instead?

There is no validation before I click "Add" and the alias shows as added after I get the error dialog. The bad alias is also listed under "main address" as well, and throws another error dialog if I try to select it there

Operating system

No response

Browser information

No response

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No

[kittykat]

Tested Netlify build. Can confirm that bad alias is now no longer added.

For me to consider this issue resolved, I would like the text entry to show an error message of this style on a malformed address:

[Palid]

@kittykat can you have a look on the newest build? I could add some better error handling, but I think taking over matrix-org/matrix-react-sdk#6180 makes more sense

[kittykat]

It should check that there is something before the : and say to add a room name, otherwise looks great!

[kittykat]

@t3chguy I just realised that the UI is super confusing. I think published address shouldn't be a text entry at all, but maybe a drop down? The only valid options as far as I can see (and I may be wrong on this) are local addresses which have been added in the section below.