Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest section header rendered in wrong place #19414

Open
HarHarLinks opened this issue Oct 17, 2021 · 12 comments
Open

Suggest section header rendered in wrong place #19414

HarHarLinks opened this issue Oct 17, 2021 · 12 comments
Labels
A-Appearance A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

Not sure, I just noticed it had happened. Probably when a room bubbled to the top by activity?

Outcome

What did you expect?

/

What happened instead?

image

Operating system

arch

Application version

nightly

How did you install the app?

aur

Homeserver

No response

Will you send logs?

No

@SimonBrandner SimonBrandner added A-Appearance A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Oct 17, 2021
@novocaine
Copy link
Contributor

Was this a one-off, or something you can consistently reproduce?

@HarHarLinks
Copy link
Contributor Author

Seems to happen every time I switch to the #community:matrix.org space, nightly 21-10-19 today

@HarHarLinks
Copy link
Contributor Author

Element Nightly version: 2021102101, still happening 100% of the time when I switch to the space. Would it be useful to submit any logs or similar?

I haven't mentioned before that if I scroll the room list enough to hit the point where the suggested collapse thing stops floating, it'll fix itself. Until I switch spaces back and forth again. It never happens with the same Low Priority section collapsy thingy in my other space (it doesn't have a suggested). I can reproduce also with different window sizes. It happens regardless of running with ozone or without.

@t3chguy
Copy link
Member

t3chguy commented Oct 25, 2021

Related #17283

@turt2live
Copy link
Member

We've fixed a case of this already and it looks very similar to what this issue describes. If you're still seeing this, please open a new issue with fresh information for reconsideration.

@HarHarLinks
Copy link
Contributor Author

I'm sorry, but I don't understand why you are closing this issue.
This is an ongoing problem and unresolved since (before) I first opened it, here is some evidence of it in Element Nightly version: 2022050701
image

It happens 100% consistently for me.

I don't know what more information you expect me to be able to provide? But just closing unresolved issues doesn't seem an appropriate way to handle things.

It feels like it has to do with how that particular floaty string is implemented. I think you need the room list to be just so long that the low priority section is still visible while the suggested rooms section is not supposed to be visible. I think it also has to do with how element/electron gets the window size (height in particular) and when scripts are applied that handle it. I would bet this is a race condition somewhere between getting the info about suggested rooms, which seems to work slightly different from the rest of the room list based on the observation that it often reacts delayed in comparison, the floaty code for that string, and getting the window size.
Alternatively I can imagine the wm reporting a wrong-ish window size to electron, e.g. calculating it including or excluding the window frame. To that end: I'm using sway with title in the window frame enabled at the top as well as waybar above it, while element is running through xwayland (since native support is broken element-hq/element-desktop#728).

@robintown
Copy link
Member

Reopening this then, with a note that this has likely the same underlying cause as #21848

@robintown robintown reopened this May 7, 2022
@HarHarLinks
Copy link
Contributor Author

image
Still in Element version: 5644c4e-react-0647aafc3a84-js-615f7f9e72fb
Olm version: 3.2.14

@MTRNord
Copy link
Contributor

MTRNord commented Aug 2, 2023

Happening for me too from time to time. I think I have seen it more often one reloads or when archiving rooms.

@t3chguy t3chguy changed the title broken room list css Suggest section header rendered in wrong place Aug 7, 2023
@HarHarLinks
Copy link
Contributor Author

I have no idea how this can't be reprod (per the label)? I see it almost any time I look at a space with sufficiently many rooms to cause y-overflow.
image

@HarHarLinks
Copy link
Contributor Author

member_room_name.mp4

@HarHarLinks
Copy link
Contributor Author

here's the same bug but with the server notices section header instead
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Appearance A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce
Projects
None yet
Development

No branches or pull requests

7 participants