Restricted rooms option gets a bit confused about itself when restricted to not-a-space

[turt2live]

Steps to reproduce

1. Create a room
2. Make another room
3. Set the restricted join rules in the second room to allow members from the first
4. Open room settings on the second room

Outcome

What did you expect?

The UI to use generic terminology, or show which room(s) are allowed into the new room.

What happened instead?

The UI here feels like it's saying the room is public to "anyone in a space", which could theoretically be anyone. This is false: the room is accessible to those who were a member of the upgraded room, which is not a space.

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

[t3chguy]

We specifically opted to default to space here, but yeah generic terminology would probably be better

[turt2live]

"Currently a space has access" is probably okay, but the other sentence is a bit too far on the misleading side I think.