Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji parsing bugged in combination with parentheses #19174

Closed
ShadowJonathan opened this issue Sep 26, 2021 · 5 comments
Closed

Emoji parsing bugged in combination with parentheses #19174

ShadowJonathan opened this issue Sep 26, 2021 · 5 comments
Labels
A-Composer A-Emoji O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ShadowJonathan
Copy link
Contributor

Steps to reproduce

  1. Type ()
  2. Have your cursor inbetween the parentheses (|)
  3. Press space ( |)
  4. Type any emoji ( :eyes:|)
  5. Observe "grin" being suggested, and suggestion not going away when going to other spots

What happened?

What did you expect?

"Eyes" to still get suggested

What happened?

"Grin" got suggested, and the emoji parsing to be a bit bugged

Operating system

Linux

Application version

Element version: 1.8.5 Olm version: 3.2.3

How did you install the app?

Flatpak

Homeserver

jboi.nl

Have you submitted a rageshake?

No

@ShadowJonathan
Copy link
Contributor Author

Additional context video;

emoji_typing-2021-09-26_11.39.37.mp4

@SimonBrandner
Copy link
Contributor

This has nothing to do with parentheses, this just happens when you finish the shortcode - write the ending :

@SimonBrandner SimonBrandner added A-Composer A-Emoji O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Sep 26, 2021
@SimonBrandner
Copy link
Contributor

I am inclined to close this in favour of #19178 though @ShadowJonathan disagrees, so I am going to leave this up to the team

@ShadowJonathan
Copy link
Contributor Author

I disagree on the basis that this is an issue onto itself, which exhibits buggy behaviour. #19178 is an enhancement which'd coincidentally fix this problem as well, but i think it's up to the team/design to decide how to fix this issue.

@robintown
Copy link
Member

Duplicate of #19302

@robintown robintown marked this as a duplicate of #19302 Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Emoji O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants