Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Membership event list summary hides leave events with no prior join when hidden events are enabled #18785

Open
turt2live opened this issue Aug 25, 2021 · 0 comments
Labels
A-ELS Event List Summary (and Membership ELS, MELS) A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect

Comments

@turt2live
Copy link
Member

Steps to reproduce

This one's a bit niche:

  1. Enable 'Show Hidden Events' under labs
  2. Crack open devtools in a room you're admin of
  3. Send an m.room.member state event for a user not in the room, eg @alice:localhost, with membership leave
  4. Do the same, but for a second user (@bob:localhost)

What happened?

image

Only the first leave event is shown. It's clear that the second one is being trapped by MELS due to the lack of timestamp on the membership event (meaning the timeline code knows there's an event which follows, but it assumes that the grouping would take care of it). However, it did not get grouped.

What did you expect?

For the second (hidden) membership event to be either part of a MELS or otherwise shown in the timeline, as it used to.

Operating system

Windows 10

Browser information

Edge 92.0.902.67 (Official build) (64-bit)

URL for webapp

local build

Homeserver

localhost (Synapse 1.40.0)

Have you submitted a rageshake?

No

@robintown robintown added A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users labels Aug 25, 2021
@MadLittleMods MadLittleMods added the A-ELS Event List Summary (and Membership ELS, MELS) label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ELS Event List Summary (and Membership ELS, MELS) A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants