Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to expand shortened replied-to message #18179

Closed
HarHarLinks opened this issue Jul 22, 2021 · 9 comments
Closed

Add toggle to expand shortened replied-to message #18179

HarHarLinks opened this issue Jul 22, 2021 · 9 comments

Comments

@HarHarLinks
Copy link
Contributor

Is your suggestion related to a problem? Please describe.

image

  • I like that it is compact by default
  • I also like not having to jump around in the timeline, which annoys me every time discord does it.

At lest discord is much faster to do it than an encrypted Element chat with the history not preloaded(?) and potentially slow server/network as it is for me so often.

Related #18017: open replied-to links and images right from the reply

All in all I think the replied-to quotes should not lose their interactiveness.

Describe the solution you'd like.

  • A toggle expand button, perhaps like a v and ^ depending on current state.
  • Element should save the state when switching back and forth between rooms.
  • Add a settings toggle for default-expanded state.

Describe alternatives you've considered.

Perhaps when the original message is still on screen, it makes sense to instead blink and highlight it without scrolling there. This makes it more complicated however and I can see arguments to just have it right at the reply anyway.

Of course going the discord route is an alternative (seems the current route), but I don't like that and think it can be better.

Additional context

Might need more changes after threading. 🤷

@SimonBrandner
Copy link
Contributor

What do you think of expanding the reply when shift-clicking or similar?

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Jul 22, 2021

I have nothing against that, but I believe there should also be a visible cue and if that exists it might probably as well be a button

@SimonBrandner
Copy link
Contributor

The thing is I don't know where to fit that button...

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Jul 22, 2021

image
Edit:
image
Edit2:
you know, the ... could just be clickable and expand the text. that probably requires #18017.

@HarHarLinks
Copy link
Contributor Author

Regarding the alternatives I proposed:
reply previews may well profit from a contextual truncating approach, like truncating it to only a single line if the original message is still on screen, and a different UI entirely if it is a reply to a direct predecessor. See more details here #18200 (comment)

@ShadowJonathan
Copy link
Contributor

Maybe this icon could be used in the top right when hovering over the message?

@HarHarLinks
Copy link
Contributor Author

perhaps the expand more (and expand less to collapse) on the same page is more fitting since it only ever expands down? that is, the quoted replied-to part is cut off at the end, never the start.

@novocaine
Copy link
Contributor

Related: #18884

@SimonBrandner
Copy link
Contributor

AFAICT, we have this now, so I am going to close this, let me know if I am missing something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants