Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading spinner has artifacts in some rotations #17642

Closed
deepbluev7 opened this issue Jun 14, 2021 · 9 comments
Closed

Loading spinner has artifacts in some rotations #17642

deepbluev7 opened this issue Jun 14, 2021 · 9 comments
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Z-Platform-Specific Z-Upstream

Comments

@deepbluev7
Copy link

Screenshot_20210614_172536

Description

I get the above artifacts around the loading spinner on initial load.

Steps to reproduce

  • Open element-web (best case you have an old session)

It should not have a rotating square around the loading indicator.

Logs being sent: yes/no

Version information

  • Platform: Web

For the web app:

  • Browser: Firefox 89
  • OS: Gentoo
  • URL: riot.neko.dev
@HarHarLinks
Copy link
Contributor

if this is going to be revised, the spinner could use some fresh paint anyway 😇

sadly the labs logo spinner, while pretty, is gone. but the current spinner does not fit the app's otherwise modern and flat look imo. further i often find it somehow manages to look not sharp, feels like i'm scaling it but it's a gif?

@deepbluev7
Copy link
Author

Yeah, I only noticed this now, since I was using the labs spinner for ages and that didn't have this issue.

@SimonBrandner
Copy link
Contributor

For a more modern spinner: matrix-org/matrix-react-sdk#6083

@robintown
Copy link
Member

I'm fairly certain that this is not an issue with the spinner itself, but rather Firefox 89. I only noticed this after the upgrade to FF 89, which I noticed finally switched over to WebRender on my machine, and I suspect this is why others are just noticing it too.

@deepbluev7
Copy link
Author

deepbluev7 commented Jun 15, 2021

That could be, but I only experience this issue after upgrading to an element version without the fancy element logo spinner, so I assumed it was related to that. (I do have webrender enabled though)

@robintown
Copy link
Member

@deepbluev7 Yes, the way the spinner is rendered was recently changed as well (to be a rotating SVG mask rather than a GIF), so that is why this only happens in recent versions

@robintown
Copy link
Member

https://bugzilla.mozilla.org/show_bug.cgi?id=1616326 appears to be where this is tracked

@licentiapoetica
Copy link

a temporary fix is to make a little custom css with the following contents:

.mx_Spinner_icon {
  background-color: #000;
  filter: invert(100);
}

@robintown robintown added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Aug 5, 2021
@robintown
Copy link
Member

This was somehow magically fixed by matrix-org/matrix-react-sdk#6083, and I have no idea why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Z-Platform-Specific Z-Upstream
Projects
None yet
Development

No branches or pull requests

5 participants