Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recent messages can freeze the UI #17564

Open
robintown opened this issue Jun 4, 2021 · 1 comment
Open

Remove recent messages can freeze the UI #17564

robintown opened this issue Jun 4, 2021 · 1 comment
Labels
A-Moderation A-Performance O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@robintown
Copy link
Member

robintown commented Jun 4, 2021 •
edited
Loading

As discussed in matrix-org/matrix-react-sdk#6114, the remove recent messages dialog can cause the UI to freeze for many seconds when redacting a lot of events at once. This is because there's no way to signal that redactions are being sent in bulk, which means that every individual cli.redactEvent call fires Room.localEchoUpdated twice just to queue itself up. TimelinePanel listens for these local echo updates and does a force update each time, meaning that if you redact n events, TimelinePanel will immediately do 2n rerenders.

cc @gsouquet
@SimonBrandner SimonBrandner added A-Moderation A-Performance S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 5, 2021
@robintown robintown mentioned this issue Jun 6, 2021
Merged
@germain-gg germain-gg self-assigned this Jun 7, 2021
@robintown robintown added the O-Uncommon Most users are unlikely to come across this or unexpected workflow label Aug 22, 2021
@germain-gg germain-gg removed their assignment Aug 27, 2021
@pReya

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Moderation A-Performance O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@germain-gg @pReya @SimonBrandner @robintown