Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI allows (trying to) verify current session #14974

Open
matthijskooijman opened this issue Aug 16, 2020 · 0 comments
Open

UI allows (trying to) verify current session #14974

matthijskooijman opened this issue Aug 16, 2020 · 0 comments
Labels
A-Session-Mgmt Session / device names, management UI, etc. T-Defect

Comments

@matthijskooijman
Copy link

Description

When verifying other logins through the "User profile" screen, you can initiate a verification of the current session, which will then just fail or block indefinitely (I didn't wait) and is pointless.

Steps to reproduce

I did not try reproducing this from scratch (in my case, I had a situation where all sessions except my new app.element.io one were already verified), but I'm assuming below would also work.

  • Log in a new app.element.io session
  • Go to "Security and privacy" settings.
  • Note which is the current session
  • Click "verify them in your User Profile" to see the session list in your profile
  • Click the current session (easiest to distinguish if it's the only one that's not verified, since the current session is not highlighted, see Session list for current user does not indicate current session #14344).
  • Click "Verify interactively by emoji" (or something like that)
  • It now tries to verify itself, waiting for itself to respond to the verification request, which will probably never happen (I waited for half a minute and then realized that this was actually the current session, so aborted and started the verification from another session).

The UI should probably not allow verification of the current session, or show a meaningful error message if you do try. In both cases, it should probably have some info on how to get the current session verified instead (this relates to #13975).

Version information

@MadLittleMods MadLittleMods added the A-Session-Mgmt Session / device names, management UI, etc. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Session-Mgmt Session / device names, management UI, etc. T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants